Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove maligned inactive linter #1492

Closed
atc0005 opened this issue Apr 7, 2024 · 0 comments · Fixed by #1502
Closed

Remove maligned inactive linter #1492

atc0005 opened this issue Apr 7, 2024 · 0 comments · Fixed by #1502
Assignees
@atc0005
Labels
bug Something isn't working linting oldstable stable unstable
Milestone
v0.20.2

Comments

@atc0005
Copy link
Owner

atc0005 commented Apr 7, 2024

This linter has been deprecated for a while with the suggestion to use govet 'fieldalignment'.

As of a recent release the linter no longer produces a report.

Related output:

golangci-lint has version 1.57.2 built with go1.22.1 from 77a8601a on 2024-03-28T19:01:11Z
level=warning msg="The linter 'maligned' is deprecated (since v1.38.0) due to: The repository of the linter has been archived by the owner. Replaced by govet 'fieldalignment'."
level=warning msg="[linters_context] maligned: This linter is fully inactivated: it will not produce any reports."

We should remove this linter from the golangci-lint config files.
@atc0005 atc0005 added this to the Next Release milestone Apr 7, 2024
@atc0005 atc0005 self-assigned this Apr 7, 2024
@atc0005 atc0005 mentioned this issue May 3, 2024
Closed
atc0005 added a commit that referenced this issue May 3, 2024
@atc0005
Remove inactive maligned linter
410b02a 
This linter has been deprecated for a while with the suggestion
to use govet 'fieldalignment'.

As of a recent release the linter no longer produces a report.

Remove the `maligned` linter from `stable`, `oldstable` and
`unstable` linter images.

refs GH-1492
refs GH-302
@atc0005 atc0005 mentioned this issue May 3, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@atc0005 atc0005

Labels
bug Something isn't working linting oldstable stable unstable
Projects
None yet
Milestone
v0.20.2
Development

Successfully merging a pull request may close this issue.

Remove inactive maligned linter atc0005/go-ci
1 participant
@atc0005