Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Dockerfiles to reflect a chosen base image OS #1057

Closed
atc0005 opened this issue Jun 16, 2023 · 0 comments · Fixed by #1062
Closed

Update Dockerfiles to reflect a chosen base image OS #1057

atc0005 opened this issue Jun 16, 2023 · 0 comments · Fixed by #1062
Assignees
@atc0005
Labels
dependencies enhancement New feature or request oldstable stable unstable
Milestone
v0.11.1

Comments

@atc0005
Copy link
Owner

atc0005 commented Jun 16, 2023

Cross-post from #1056 (comment):

The "fix" was to update dependencies to reflect that Debian 12 is now used as the base image.

It looks like this may cause issues for some builds based on that image:

Since the majority of projects using images provided by this repo explicitly configure static builds this may not be an issue, but additional testing is needed to confirm.

and from #1056 (reply in thread):

Since the majority of projects using images provided by this repo explicitly configure static builds this may not be an issue, but additional testing is needed to confirm.

I generated various test builds and installed the "dev" variants of the packages on a Nagios XI box. The "test" service checks ran for a bit and did not encounter any unexpected issues.

For my purposes the base image change from Debian 11 to Debian 12 does not appear to be impacting anything.

Even so, going forward I probably should update the Dockerfiles to explicitly reflect a chosen base image OS.
@atc0005 atc0005 added this to the Next Release milestone Jun 16, 2023
@atc0005 atc0005 self-assigned this Jun 16, 2023
@atc0005 atc0005 mentioned this issue Jun 23, 2023
Closed
atc0005 added a commit that referenced this issue Jun 26, 2023
@atc0005
Update Dockerfiles to specify chosen base image OS
659ca72 
These images were updated to use the most recent stable
base image OS available:

- mirror images
- oldstable images
- stable images

The bump to Go 1.21rc2 for the unstable images also included
the change to specify the base image OS.

NOTE:

Going forward the base image OS will likely stay the same for
the life of the specific series reflected in the image type.

For example, Debian "bookworm" was recently released. When
Go 1.21.0 is released as the next stable version, the "stable"
Debian-based images will continue to use the "bookworm" OS
as the base image for the life of the Go 1.21 series. If a
newer Debian OS version is available when Go 1.22.0 is released
then the "stable" images will adopt that Debian OS as the base
image OS for Debian-based images. The 1.21 series will continue
to use the former Debian OS as the base image OS (for
Debian-based images).

refs GH-1057
refs GH-1058
atc0005 added a commit that referenced this issue Jun 26, 2023
@atc0005
Update Dockerfiles to specify chosen base image OS
df7aae9 
These images were updated to use the most recent stable
base image OS available:

- mirror images
- oldstable images
- stable images

The bump to Go 1.21rc2 for the unstable images also included
the change to specify the base image OS.

NOTE:

Going forward the base image OS will likely stay the same for
the life of the specific series reflected in the image type.

For example, Debian "bookworm" was recently released. When
Go 1.21.0 is released as the next stable version, the "stable"
Debian-based images will continue to use the "bookworm" OS
as the base image for the life of the Go 1.21 series. If a
newer Debian OS version is available when Go 1.22.0 is released
then the "stable" images will adopt that Debian OS as the base
image OS for Debian-based images. The 1.21 series will continue
to use the former Debian OS as the base image OS (for
Debian-based images).

refs GH-1057
refs GH-1058
@atc0005 atc0005 added the enhancement New feature or request label Jun 26, 2023
@atc0005 atc0005 mentioned this issue Jun 26, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@atc0005 atc0005

Labels
dependencies enhancement New feature or request oldstable stable unstable
Projects
None yet
Milestone
v0.11.1
Development

Successfully merging a pull request may close this issue.

Update Dockerfiles to specify chosen base image OS atc0005/go-ci
1 participant
@atc0005