Skip to content
This repository has been archived by the owner on Dec 29, 2019. It is now read-only.

[impl-j] Visitor pattern #27

Closed
at15 opened this issue Nov 27, 2017 · 0 comments
Closed

[impl-j] Visitor pattern #27

at15 opened this issue Nov 27, 2017 · 0 comments
Assignees
@at15
Labels
bug p1
Milestone
0.0.5

Comments

@at15
Copy link
Owner

at15 commented Nov 27, 2017 •
edited
Loading

It is used when traverse ANTLR generated parse tree, also mentioned in ANTLR3 book P113 External Tree Visitor

  • it seems the accept method, although identical, need to be declared in every subclass of node
@at15 at15 self-assigned this Nov 27, 2017
@at15 at15 added this to the 0.1 milestone Nov 27, 2017
at15 added a commit that referenced this issue Nov 27, 2017
@at15
[j][bug] Type checker visitor stackoverflow #27
7832188 
- when implementing #24, triggered #27
- seems I didn't figure out the right way to use visitor, it is not
dispatched to the right node? or I need to rename
at15 added a commit that referenced this issue Nov 27, 2017
@at15
[j] Add accept in every node seems work for #27
f83be30 
- without override in every subclass, when accept is called, it calls
visitor.visit(this), and this is of abstract class Node, however in
visitor, visit(Node n) just calls n.accept, cause the recursion ...
at15 added a commit that referenced this issue Nov 27, 2017
@at15
[j] n.accept(checker) -> checker.visit(n) #27
a9c6a0a 
- when we have Node n, and call checker.visit(n), visit(Node n) would
call n.accept(this), which is same as root.accept(checker)
@at15 at15 mentioned this issue Nov 27, 2017
Merged
@at15 at15 closed this as completed in #25 Nov 27, 2017
@at15 at15 mentioned this issue Nov 27, 2017
Open
6 tasks
at15 added a commit that referenced this issue Nov 30, 2017
@at15
[talk] Add example for visitor pattern #27
b65f3f4 
- also created a simple language SimpleBin to show how to use visitor
pattern to do type check and evaluation
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@at15 at15

Labels
bug p1
Projects
None yet
Milestone
0.0.5
Development

No branches or pull requests
1 participant
@at15