Skip to content

Conversation

@mcturco
Copy link
Member

@mcturco mcturco commented Dec 30, 2021

I am proposing a few quick styling tweaks as follows:

1. Left-align block of text next to home page animation
Seems silly, but I think this section looks a little more polished with the text left-aligned. On mobile, the text goes back to being centered.

Before:
Screen Shot 2021-12-30 at 2 06 31 PM

After:
Screen Shot 2021-12-30 at 2 06 22 PM


2. Add a thin gray border around the cards in the Features section
Also a very minor visual tweak, but I thought that these cards should visually compare to the next chapter links in the docs. It also just sets the white cards a bit more from the background, whereas right now they look like they are blending in with the white background towards the top.

Before:
Screen Shot 2021-12-30 at 2 11 50 PM

After:
Screen Shot 2021-12-30 at 2 12 05 PM


3. Adding a thin gray border around the blog cards on the home page as well as hover states
Again, just matching the card style on the docs pages for consistency.

Before:
Screen Shot 2021-12-30 at 2 14 10 PM

After:
Screen Shot 2021-12-30 at 2 14 50 PM


P.S. This is also just me trying to get a feel for how styles are applied to the website and I just found some easy things to improve on along the way 😄

@netlify
Copy link

netlify bot commented Dec 30, 2021

✔️ Deploy Preview for asyncapi-website ready!
Built without sensitive environment variables

🔨 Explore the source changes: 3fb1190

🔍 Inspect the deploy log: https://app.netlify.com/sites/asyncapi-website/deploys/61d31ee1cd0d580007adf5b3

😎 Browse the preview: https://deploy-preview-522--asyncapi-website.netlify.app

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome to AsyncAPI. Thanks a lot for creating your first pull request. Please check out our contributors guide useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.

@mcturco
Copy link
Member Author

mcturco commented Dec 31, 2021

One more thing: in the last commit, I just matched the grid gap of this section:
Screen Shot 2021-12-30 at 2 11 50 PM

to this section:
Screen Shot 2021-12-30 at 2 14 50 PM

So now, the features section looks like this:
Screen Shot 2021-12-31 at 10 12 37 AM

Yay for consistent grid spacing!! 😄

@magicmatatjahu
Copy link
Member

@mcturco Great to see your first PR in website ❤️ I like the current changes, but we could still change more things:

  • reducing the shadow in cards in the Features section - currently it is bigger than for blog posts
  • adding the same entry animation, like in cards in the Features section, in cards for blog posts, atm there isn't any hover animation.

That two things for consistency, rest things looks good :)

@magicmatatjahu
Copy link
Member

And last thing, because I tested it in mobile devices. In some breakpoint I see this:

image

I think that the content on the right should be aligned to the top without margin-top, maybe with some extra margin on the left to increase gap between left content and right?. What do you think? :)

@mcturco
Copy link
Member Author

mcturco commented Jan 3, 2022

@magicmatatjahu thanks for your review!! And I am happy to be making code contributions 😄

reducing the shadow in cards in the Features section - currently it is bigger than for blog posts
adding the same entry animation, like in cards in the Features section, in cards for blog posts, atm there isn't any hover animation.

Good call! I didn't notice that at first. Just added a commit for that!

I think that the content on the right should be aligned to the top without margin-top, maybe with some extra margin on the left to increase gap between left content and right?

AGREED!! I just made those adjustments and I think it looks a lot cleaner. Thank you!! 🤩

Copy link
Member

@magicmatatjahu magicmatatjahu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀

@mcturco
Copy link
Member Author

mcturco commented Jan 3, 2022

@magicmatatjahu YAY how exciting!!! 😄

@mcturco
Copy link
Member Author

mcturco commented Jan 3, 2022

/rtm

@magicmatatjahu
Copy link
Member

/rtm

@asyncapi-bot asyncapi-bot merged commit e4e54d7 into asyncapi:master Jan 3, 2022
@mcturco mcturco deleted the homepage-features-styling branch January 3, 2022 16:20
atharva038 pushed a commit to atharva038/asyncapi that referenced this pull request Oct 23, 2025
ci: update global workflows
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants