Skip to content

Conversation

@princerajpoot20
Copy link
Member

@princerajpoot20 princerajpoot20 commented Nov 19, 2025

Related issue(s)

Resolves #4594

Summary by CodeRabbit

  • Chores
    • Updated testing infrastructure configuration for improved compatibility with latest macOS versions.

@netlify
Copy link

netlify bot commented Nov 19, 2025

Deploy Preview for asyncapi-website ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit def1839
🔍 Latest deploy log https://app.netlify.com/projects/asyncapi-website/deploys/691ddf15d2fca8000804065c
😎 Deploy Preview https://deploy-preview-4625--asyncapi-website.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Nov 19, 2025

Walkthrough

Updated the GitHub Actions workflow matrix to use macos-latest instead of the deprecated macos-13 runner image. This change maintains compatibility with GitHub Actions' deprecation timeline while keeping all other OS entries unchanged.

Changes

Cohort / File(s) Summary
macOS Runner Update
\.github/workflows/if-nodejs-pr-testing\.yml
Changed macOS runner matrix entry from macos-13 to macos-latest

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

Suggested reviewers

  • derberg
  • sambhavgupta0705
  • akshatnema
  • Mayaleeeee

Poem

🐰 A hop, skip, and update we go,
From macos-13 to the latest flow,
No more deprecated runners in sight,
Just modern CI workflows, shiny and bright! ✨

Pre-merge checks and finishing touches

❌ Failed checks (1 inconclusive)
Check name Status Explanation Resolution
Linked Issues check ❓ Inconclusive The PR addresses issue #4594 by migrating from macOS-13 to a newer image, though it uses macos-latest instead of the explicitly mentioned macOS-15. Verify that macos-latest resolves to macOS-15 or a supported version that meets the deprecation deadline specified in the GitHub changelog.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: migrating macOS runner from macOS-13 to macos-latest, which matches the file modification.
Out of Scope Changes check ✅ Passed The changes are limited to the workflow file and directly address the macOS migration requirement from the linked issue without introducing unrelated modifications.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

📜 Recent review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between e63c6c3 and def1839.

📒 Files selected for processing (1)
  • .github/workflows/if-nodejs-pr-testing.yml (1 hunks)
🧰 Additional context used
🧠 Learnings (1)
📚 Learning: 2024-11-25T18:41:29.632Z
Learnt from: akshatnema
Repo: asyncapi/website PR: 3378
File: scripts/markdown/check-markdown.js:1-1
Timestamp: 2024-11-25T18:41:29.632Z
Learning: When updating workflows for the AsyncAPI website repository, use `.github/workflows/if-nodejs-pr-testing.yml` to include environment variables and secrets for Node.js PR testing.

Applied to files:

  • .github/workflows/if-nodejs-pr-testing.yml
⏰ Context from checks skipped due to timeout of 180000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (5)
  • GitHub Check: cypress-run
  • GitHub Check: Redirect rules - asyncapi-website
  • GitHub Check: Header rules - asyncapi-website
  • GitHub Check: Pages changed - asyncapi-website
  • GitHub Check: Lighthouse CI
🔇 Additional comments (1)
.github/workflows/if-nodejs-pr-testing.yml (1)

16-16: Approved: macOS runner image migration is correct and complete.

The change from macos-13 to macos-latest is the appropriate migration path given GitHub's deprecation of the macOS-13 runner. This ensures the workflow continues to execute on a supported, modern macOS image. The change is minimal, targeted, and introduces no breaking modifications to the workflow logic.

Tip

📝 Customizable high-level summaries are now available in beta!

You can now customize how CodeRabbit generates the high-level summary in your pull requests — including its content, structure, tone, and formatting.

  • Provide your own instructions using the high_level_summary_instructions setting.
  • Format the summary however you like (bullet lists, tables, multi-section layouts, contributor stats, etc.).
  • Use high_level_summary_in_walkthrough to move the summary from the description to the walkthrough section.

Example instruction:

"Divide the high-level summary into five sections:

  1. 📝 Description — Summarize the main change in 50–60 words, explaining what was done.
  2. 📓 References — List relevant issues, discussions, documentation, or related PRs.
  3. 📦 Dependencies & Requirements — Mention any new/updated dependencies, environment variable changes, or configuration updates.
  4. 📊 Contributor Summary — Include a Markdown table showing contributions:
    | Contributor | Lines Added | Lines Removed | Files Changed |
  5. ✔️ Additional Notes — Add any extra reviewer context.
    Keep each section concise (under 200 words) and use bullet or numbered lists for clarity."

Note: This feature is currently in beta for Pro-tier users, and pricing will be announced later.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@asyncapi-bot
Copy link
Contributor

⚡️ Lighthouse report for the changes in this PR:

Category Score
🔴 Performance 42
🟢 Accessibility 98
🟢 Best practices 92
🟢 SEO 100
🔴 PWA 33

Lighthouse ran on https://deploy-preview-4625--asyncapi-website.netlify.app/

@codecov
Copy link

codecov bot commented Nov 19, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (e63c6c3) to head (def1839).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##            master     #4625   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           22        22           
  Lines          799       799           
  Branches       146       146           
=========================================
  Hits           799       799           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Member

@sambhavgupta0705 sambhavgupta0705 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@sambhavgupta0705 sambhavgupta0705 merged commit d9e34fc into asyncapi:master Nov 19, 2025
32 of 35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

upgrade macOS-13 image

3 participants