-
-
Notifications
You must be signed in to change notification settings - Fork 1k
chore: update meetings.json and newsrooom_videos.json #4563
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: update meetings.json and newsrooom_videos.json #4563
Conversation
WalkthroughThree video entries in the newsroom configuration file are updated with new metadata values, including image URLs, titles, descriptions, and video IDs. The file structure and overall configuration remain unchanged. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes
Possibly related PRs
Suggested reviewers
Poem
Pre-merge checks and finishing touches❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #4563 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 22 22
Lines 799 799
Branches 146 146
=========================================
Hits 799 799 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
✅ Deploy Preview for asyncapi-website ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
📜 Review details
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
config/newsroom_videos.json(1 hunks)
⏰ Context from checks skipped due to timeout of 180000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (6)
- GitHub Check: Redirect rules - asyncapi-website
- GitHub Check: Header rules - asyncapi-website
- GitHub Check: Pages changed - asyncapi-website
- GitHub Check: Automerge PR autoapproved by a bot
- GitHub Check: Lighthouse CI
- GitHub Check: Test NodeJS PR - windows-latest
🔇 Additional comments (1)
config/newsroom_videos.json (1)
15-30: Verify description field consistency.The updated entries (lines 15-30) use GitHub issue URLs only for the
descriptionfield, while the existing entry on line 11 includes descriptive text. Verify this is the intended behavior for the automated update, or consider adding meaningful descriptions alongside or instead of the URLs.
| "image_url": "https://i.ytimg.com/vi/gn6765Le_zQ/hqdefault.jpg", | ||
| "title": "AsyncAPI Community WG Meeting, Tuesday September 23rd 2025", | ||
| "description": "https://github.com/asyncapi/community/issues/2066.", | ||
| "videoId": "gn6765Le_zQ" | ||
| }, | ||
| { | ||
| "image_url": "https://i.ytimg.com/vi/nNl0HUdBnmg/hqdefault.jpg", | ||
| "title": "Kickstart your AsyncAPI journey with Springwolf", | ||
| "description": "Join us on the 14th of October at 4 PM UTC for a deep dive into Springwolf, the open-source solution for generating AsyncAPI ...", | ||
| "videoId": "nNl0HUdBnmg" | ||
| "image_url": "https://i.ytimg.com/vi/m-aLlapR2Mg/hqdefault.jpg", | ||
| "title": "AsyncAPI Community WG Meeting , Tuesday September 9th 2025", | ||
| "description": "https://github.com/asyncapi/community/issues/2060.", | ||
| "videoId": "m-aLlapR2Mg" | ||
| }, | ||
| { | ||
| "image_url": "https://i.ytimg.com/vi/Mkd7FgKOMNE/hqdefault.jpg", | ||
| "title": "One Tool, One Flow: AsyncAPI's New Take on Code/Docs/Config Generation", | ||
| "description": "Join us on September 30th at 4PM UTC for the first session of our AsyncAPI webinar series with Łukasz. In “One Tool, One Flow: ...", | ||
| "videoId": "Mkd7FgKOMNE" | ||
| "image_url": "https://i.ytimg.com/vi/7vvdmDVZPX0/hqdefault.jpg", | ||
| "title": "AsyncAPI Community WG Meeting , Tuesday July 29th 2025", | ||
| "description": "https://github.com/asyncapi/community/issues/1988.", | ||
| "videoId": "7vvdmDVZPX0" | ||
| } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor formatting inconsistency in titles.
Lines 22 and 28 have an extra space before the comma in the title field ("Meeting ," vs. "Meeting,"), which differs from line 16 and is inconsistent with standard formatting conventions.
Apply this diff to remove the extra spaces:
- "title": "AsyncAPI Community WG Meeting , Tuesday September 9th 2025",
+ "title": "AsyncAPI Community WG Meeting, Tuesday September 9th 2025",- "title": "AsyncAPI Community WG Meeting , Tuesday July 29th 2025",
+ "title": "AsyncAPI Community WG Meeting, Tuesday July 29th 2025",📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| "image_url": "https://i.ytimg.com/vi/gn6765Le_zQ/hqdefault.jpg", | |
| "title": "AsyncAPI Community WG Meeting, Tuesday September 23rd 2025", | |
| "description": "https://github.com/asyncapi/community/issues/2066.", | |
| "videoId": "gn6765Le_zQ" | |
| }, | |
| { | |
| "image_url": "https://i.ytimg.com/vi/nNl0HUdBnmg/hqdefault.jpg", | |
| "title": "Kickstart your AsyncAPI journey with Springwolf", | |
| "description": "Join us on the 14th of October at 4 PM UTC for a deep dive into Springwolf, the open-source solution for generating AsyncAPI ...", | |
| "videoId": "nNl0HUdBnmg" | |
| "image_url": "https://i.ytimg.com/vi/m-aLlapR2Mg/hqdefault.jpg", | |
| "title": "AsyncAPI Community WG Meeting , Tuesday September 9th 2025", | |
| "description": "https://github.com/asyncapi/community/issues/2060.", | |
| "videoId": "m-aLlapR2Mg" | |
| }, | |
| { | |
| "image_url": "https://i.ytimg.com/vi/Mkd7FgKOMNE/hqdefault.jpg", | |
| "title": "One Tool, One Flow: AsyncAPI's New Take on Code/Docs/Config Generation", | |
| "description": "Join us on September 30th at 4PM UTC for the first session of our AsyncAPI webinar series with Łukasz. In “One Tool, One Flow: ...", | |
| "videoId": "Mkd7FgKOMNE" | |
| "image_url": "https://i.ytimg.com/vi/7vvdmDVZPX0/hqdefault.jpg", | |
| "title": "AsyncAPI Community WG Meeting , Tuesday July 29th 2025", | |
| "description": "https://github.com/asyncapi/community/issues/1988.", | |
| "videoId": "7vvdmDVZPX0" | |
| } | |
| "image_url": "https://i.ytimg.com/vi/gn6765Le_zQ/hqdefault.jpg", | |
| "title": "AsyncAPI Community WG Meeting, Tuesday September 23rd 2025", | |
| "description": "https://github.com/asyncapi/community/issues/2066.", | |
| "videoId": "gn6765Le_zQ" | |
| }, | |
| { | |
| "image_url": "https://i.ytimg.com/vi/m-aLlapR2Mg/hqdefault.jpg", | |
| "title": "AsyncAPI Community WG Meeting, Tuesday September 9th 2025", | |
| "description": "https://github.com/asyncapi/community/issues/2060.", | |
| "videoId": "m-aLlapR2Mg" | |
| }, | |
| { | |
| "image_url": "https://i.ytimg.com/vi/7vvdmDVZPX0/hqdefault.jpg", | |
| "title": "AsyncAPI Community WG Meeting, Tuesday July 29th 2025", | |
| "description": "https://github.com/asyncapi/community/issues/1988.", | |
| "videoId": "7vvdmDVZPX0" | |
| } |
🤖 Prompt for AI Agents
In config/newsroom_videos.json around lines 15 to 31, the title fields on lines
~22 and ~28 contain an extra space before the comma ("Meeting ,"); remove the
stray space so the titles read "Meeting, Tuesday ..." matching the formatting
used on line 16; update those two title strings accordingly and ensure there are
no other stray spaces before punctuation in this block.
|
⚡️ Lighthouse report for the changes in this PR:
Lighthouse ran on https://deploy-preview-4563--asyncapi-website.netlify.app/ |
Automated changes by create-pull-request GitHub action
Summary by CodeRabbit