-
-
Notifications
You must be signed in to change notification settings - Fork 1k
chore: update meetings.json and newsrooom_videos.json #4393
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: update meetings.json and newsrooom_videos.json #4393
Conversation
✅ Deploy Preview for asyncapi-website ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
WalkthroughUpdated config/meetings.json by deleting the "Design WG Meeting" entry and replacing the "GSoC Welcome Contributors Call" entry with a new "Marketing WG Meeting" entry, updating its calLink, url, and date. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Suggested labels
Suggested reviewers
Poem
✨ Finishing Touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #4393 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 22 22
Lines 778 778
Branches 144 144
=========================================
Hits 778 778 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
⚡️ Lighthouse report for the changes in this PR:
Lighthouse ran on https://deploy-preview-4393--asyncapi-website.netlify.app/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (3)
config/meetings.json (3)
10-10: Confirm uniqueness keying for repeated titles.There are multiple “Marketing WG Meeting” entries. If clients key by title, this may collide. Prefer a stable id (e.g., slug or calendar event id) or composite key (title+date).
13-13: Banner consistency.Many Community WG items include a banner; Marketing WG items are blank. If the UI expects consistency, consider adding or standardizing.
94-94: Trim trailing space in title.Found: "AsyncAPI Design WG Meeting " (note trailing space). Minor, but can break exact-match filters.
Apply:
- "title": "AsyncAPI Design WG Meeting ", + "title": "AsyncAPI Design WG Meeting",
📜 Review details
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
config/meetings.json(1 hunks)
⏰ Context from checks skipped due to timeout of 180000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (4)
- GitHub Check: Automerge PR autoapproved by a bot
- GitHub Check: Test NodeJS PR - windows-latest
- GitHub Check: Test NodeJS PR - macos-13
- GitHub Check: Lighthouse CI
🔇 Additional comments (1)
config/meetings.json (1)
10-14: Future-dated entry OK; verify consumers don’t rely on chronological order.This object (2025-10-06) sits between June entries. If any consumer assumes the array is sorted, consider reordering or ensure sorting is applied at read time.
Automated changes by create-pull-request GitHub action
Summary by CodeRabbit