-
-
Notifications
You must be signed in to change notification settings - Fork 996
chore: update meetings.json and newsrooom_videos.json #4373
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: update meetings.json and newsrooom_videos.json #4373
Conversation
WalkthroughA single meeting entry was appended to config/meetings.json: "AsyncAPI Webinar With Lukasz" with specified Google Calendar link, GitHub issue URL, empty banner, and date 2025-09-30T16:00:00.000Z. No other entries were modified. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Possibly related PRs
Suggested labels
Suggested reviewers
Poem
✨ Finishing Touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
Status, Documentation and Community
|
✅ Deploy Preview for asyncapi-website ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #4373 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 22 22
Lines 778 778
Branches 144 144
=========================================
Hits 778 778 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
⚡️ Lighthouse report for the changes in this PR:
Lighthouse ran on https://deploy-preview-4373--asyncapi-website.netlify.app/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
config/meetings.json (1)
129-129: Nit: consider proper name diacritic.If the speaker is Łukasz Górnicki and the site elsewhere uses “Łukasz”, update the title for consistency.
📜 Review details
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
💡 Knowledge Base configuration:
- MCP integration is disabled by default for public repositories
- Jira integration is disabled by default for public repositories
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (1)
config/meetings.json(1 hunks)
⏰ Context from checks skipped due to timeout of 180000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
- GitHub Check: Automerge PR autoapproved by a bot
- GitHub Check: Test NodeJS PR - windows-latest
- GitHub Check: Lighthouse CI
🔇 Additional comments (3)
config/meetings.json (3)
127-133: LGTM: new meeting entry looks consistent.Fields match existing schema/order; JSON remains valid; placement after 2025-08-26 entry is fine for a 2025-09-30 event.
129-133: Date/time confirmed as correct: 2025-09-30T16:00:00.000Z aligns with GitHub issue #2052 (16:00 UTC, Sep 30 2025) and the AsyncAPI calendar; JSON entry includes all required keys.
132-132: Empty banner safe: fallback applies
EventPostItem usespost.banner ? post.banner : defaultCover, so"",nullorundefinedall fall back to the default cover image—no changes needed.
Automated changes by create-pull-request GitHub action
Summary by CodeRabbit