-
-
Notifications
You must be signed in to change notification settings - Fork 980
chore: update meetings.json and newsrooom_videos.json #4202
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: update meetings.json and newsrooom_videos.json #4202
Conversation
✅ Deploy Preview for asyncapi-website ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
WalkthroughThe meetings configuration was updated by removing a past event and adding a new AsyncAPI Community WG Meeting scheduled for July 1, 2025. The newsroom videos configuration was revised by replacing three video entries with updated metadata, including new titles, descriptions, video IDs, and thumbnail URLs. Changes
Possibly related PRs
Suggested labels
Suggested reviewers
Poem
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (2)
config/newsroom_videos.json (2)
15-18: Inconsistent title formatting for GSoC video entry.
The GSoC welcome call title uses a pipe (|) as a separator, whereas other entries consistently use a comma before the date. Consider unifying the format:- "title": "GSoC Welcome Contributors Call | May 29th 2025", + "title": "GSoC Welcome Contributors Call, May 29th 2025",
27-30: Typo in title spacing.
The title"AsyncAPI Design WG Meeting, Thursday May 15th 2025"contains two spaces between "Design" and "WG". Reduce to one space for consistency:- "title": "AsyncAPI Design WG Meeting, Thursday May 15th 2025", + "title": "AsyncAPI Design WG Meeting, Thursday May 15th 2025",
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
config/meetings.json(1 hunks)config/newsroom_videos.json(1 hunks)
⏰ Context from checks skipped due to timeout of 180000ms (8)
- GitHub Check: Automerge PR autoapproved by a bot
- GitHub Check: Redirect rules - asyncapi-website
- GitHub Check: Header rules - asyncapi-website
- GitHub Check: Pages changed - asyncapi-website
- GitHub Check: Test NodeJS PR - windows-latest
- GitHub Check: Test NodeJS PR - ubuntu-latest
- GitHub Check: Test NodeJS PR - macos-13
- GitHub Check: Lighthouse CI
🔇 Additional comments (2)
config/meetings.json (1)
155-162: New event appended correctly; verify JSON structure and timing.
The new "AsyncAPI Community WG Meeting" entry is properly appended with the required keys (title,calLink,url,banner,date) and the previous object’s closing comma was updated to maintain valid JSON. Ensure that the scheduled timestamp (2025-07-01T15:00:00.000Z) aligns with the planned meeting time.config/newsroom_videos.json (1)
21-24: Metadata alignment: confirm video details.
The entry for the AsyncAPI Community WG Meeting on May 20th 2025 matches the corresponding event URL (issues/1897) and appears well-formed. Please verify that thevideoId(QqWUcSodtYI) andimage_urlpoint to the correct published video assets.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4202 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 22 22
Lines 778 778
Branches 144 144
=========================================
Hits 778 778 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Automated changes by create-pull-request GitHub action
Summary by CodeRabbit
New Features
Updates