-
-
Notifications
You must be signed in to change notification settings - Fork 1k
chore: update meetings.json and newsrooom_videos.json #4195
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: update meetings.json and newsrooom_videos.json #4195
Conversation
✅ Deploy Preview for asyncapi-website ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
WalkthroughThe changes update two JSON configuration files: one meeting entry was removed and a new meeting was added in Changes
Possibly related PRs
Suggested labels
Suggested reviewers
Poem
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
config/meetings.json(1 hunks)config/newsroom_videos.json(1 hunks)
⏰ Context from checks skipped due to timeout of 180000ms (8)
- GitHub Check: Automerge PR autoapproved by a bot
- GitHub Check: Redirect rules - asyncapi-website
- GitHub Check: Header rules - asyncapi-website
- GitHub Check: Pages changed - asyncapi-website
- GitHub Check: Test NodeJS PR - windows-latest
- GitHub Check: Test NodeJS PR - ubuntu-latest
- GitHub Check: Test NodeJS PR - macos-13
- GitHub Check: Lighthouse CI
🔇 Additional comments (1)
config/meetings.json (1)
155-162: New meeting entry appended in correct chronological order
The “Marketing WG Meeting” for 2025-06-24 is inserted after the 2025-06-19 Design WG meeting, with all required fields present and JSON syntax valid.
| { | ||
| "image_url": "https://i.ytimg.com/vi/0srKJiLCIUc/hqdefault.jpg", | ||
| "title": "AsyncAPI Design WG Meeting, Tuesday June 17th 2025", | ||
| "description": "https://github.com/asyncapi/community/issues/1935.", | ||
| "videoId": "0srKJiLCIUc" | ||
| }, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mismatch between video title and issue link
The new entry’s title refers to the “AsyncAPI Design WG Meeting, Tuesday June 17th 2025” but the description URL points to issue #1935 (Community WG Meeting). It should reference the Design WG issue #1955 instead.
Proposed fix:
{
- "image_url": "https://i.ytimg.com/vi/0srKJiLCIUc/hqdefault.jpg",
- "title": "AsyncAPI Design WG Meeting, Tuesday June 17th 2025",
- "description": "https://github.com/asyncapi/community/issues/1935.",
+ "image_url": "https://i.ytimg.com/vi/0srKJiLCIUc/hqdefault.jpg",
+ "title": "AsyncAPI Design WG Meeting, Tuesday June 17th 2025",
+ "description": "https://github.com/asyncapi/community/issues/1955.",
"videoId": "0srKJiLCIUc"
},📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| { | |
| "image_url": "https://i.ytimg.com/vi/0srKJiLCIUc/hqdefault.jpg", | |
| "title": "AsyncAPI Design WG Meeting, Tuesday June 17th 2025", | |
| "description": "https://github.com/asyncapi/community/issues/1935.", | |
| "videoId": "0srKJiLCIUc" | |
| }, | |
| { | |
| "image_url": "https://i.ytimg.com/vi/0srKJiLCIUc/hqdefault.jpg", | |
| "title": "AsyncAPI Design WG Meeting, Tuesday June 17th 2025", | |
| "description": "https://github.com/asyncapi/community/issues/1955.", | |
| "videoId": "0srKJiLCIUc" | |
| }, |
🤖 Prompt for AI Agents
In config/newsroom_videos.json around lines 2 to 7, the description URL for the
video entry incorrectly points to issue #1935 (Community WG Meeting) while the
title refers to the Design WG Meeting on June 17th, 2025. Update the description
URL to reference the correct Design WG issue #1955 instead of #1935.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4195 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 22 22
Lines 778 778
Branches 144 144
=========================================
Hits 778 778 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Automated changes by create-pull-request GitHub action
Summary by CodeRabbit
New Features
Chores