-
-
Notifications
You must be signed in to change notification settings - Fork 996
chore: update meetings.json and newsrooom_videos.json #4058
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: update meetings.json and newsrooom_videos.json #4058
Conversation
WalkthroughThis update modifies two JSON configuration files. In Changes
Possibly related PRs
Suggested labels
Suggested reviewers
Poem
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
✅ Deploy Preview for asyncapi-website ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4058 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 21 21
Lines 671 671
Branches 115 115
=========================================
Hits 671 671 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
config/meetings.json (1)
121-127: Nit: Remove trailing whitespace in the title
Thetitlefield on line 122 ends with an extra space ("Design WG Meeting "). Trimming it to"Design WG Meeting"will improve consistency with other entries.
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
config/meetings.json(1 hunks)config/newsroom_videos.json(1 hunks)
⏰ Context from checks skipped due to timeout of 180000ms (6)
- GitHub Check: Redirect rules - asyncapi-website
- GitHub Check: Header rules - asyncapi-website
- GitHub Check: Pages changed - asyncapi-website
- GitHub Check: Automerge PR autoapproved by a bot
- GitHub Check: Lighthouse CI
- GitHub Check: Test NodeJS PR - windows-latest
🔇 Additional comments (2)
config/meetings.json (1)
113-120: New AsyncAPI Community WG Meeting entry looks good
The added object at lines 113–120 follows the existing schema and includes all required fields (title,calLink,url,banner,date), and the JSON comma placement is correct.config/newsroom_videos.json (1)
26-31: New video entry is valid
The newly appended video object includes all required properties (image_url,title,description,videoId) and fits the existing list format. JSON punctuation is correct.
Automated changes by create-pull-request GitHub action
Summary by CodeRabbit
New Features
Chores