Skip to content

Conversation

@Priyadharshini0101
Copy link
Contributor

@Priyadharshini0101 Priyadharshini0101 commented Apr 3, 2025

Description

  • The banner on the homepage is partially hidden behind the navbar. This affects visibility and impacts the user experience.
  • The banner should be fully visible below the navbar without any overlap.

Resolves #4008

Summary by CodeRabbit

  • Style
    • Updated the announcement banner’s spacing to feature balanced vertical margins.
    • Adjusted the layout of the announcement hero section by removing the vertical alignment class for its elements.
    • Modified the scaling and visual representation of the ArrowLeft icon for improved display.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Apr 3, 2025

Walkthrough

This pull request modifies two UI components by adjusting CSS class strings. In the AnnouncementBanner component, the non-small banner now uses my-6 instead of a fixed bottom margin, applying vertical spacing on both top and bottom. In the AnnouncementHero component, the items-center class has been removed from a container div, altering how child elements are vertically aligned. Additionally, the viewBox attribute of the ArrowLeft component's SVG has been changed, affecting its display without altering internal paths. There are no changes to public interfaces.

Changes

Files Change Summary
components/.../AnnouncementBanner.tsx Updated class names: for non-small banners, changed from mx-3 mb-6 mt-3 p-3 to mx-3 my-6 p-3 (applies vertical spacing on top and bottom).
components/.../AnnouncementHero.tsx Removed the items-center class from a container div, modifying the vertical alignment of its child elements.
components/.../ArrowLeft.tsx Modified the viewBox attribute of the <svg> element from '0 0 16 20' to '0 0 20 20', and replaced the d attribute with a simpler path data for the icon.

Assessment against linked issues

Objective Addressed Explanation
Banner fully visible below navbar [#4008]

Suggested labels

ready-to-merge

Suggested reviewers

  • derberg
  • magicmatatjahu
  • Mayaleeeee
  • asyncapi-bot-eve
  • sambhavgupta0705
  • anshgoyalevil

Poem

I'm a bunny hopping on code so fair,
Adjusting margins with style and care.
No overlap hides my banner glow,
With tweaks that let the layout show.
Happy hops in fields of UI delight!
🐇💻

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 ESLint

If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.

npm warn config production Use --omit=dev instead.
npm warn EBADENGINE Unsupported engine {
npm warn EBADENGINE package: '@tisoap/[email protected]',
npm warn EBADENGINE required: { node: '>=16', npm: '^8.0.0' },
npm warn EBADENGINE current: { node: 'v22.9.0', npm: '10.8.3' }
npm warn EBADENGINE }
npm error code E503
npm error 503 Service Unavailable - GET http://10.0.0.28:4873/@parcel/watcher-wasm/-/watcher-wasm-2.4.1.tgz
npm error A complete log of this run can be found in: /.npm/_logs/2025-04-06T10_16_56_005Z-debug-0.log


📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 5d9cd49 and 491f4a9.

📒 Files selected for processing (2)
  • components/campaigns/AnnouncementHero.tsx (1 hunks)
  • components/icons/ArrowLeft.tsx (1 hunks)
🚧 Files skipped from review as they are similar to previous changes (2)
  • components/campaigns/AnnouncementHero.tsx
  • components/icons/ArrowLeft.tsx

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai plan to trigger planning for file edits and PR creation.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome to AsyncAPI. Thanks a lot for creating your first pull request. Please check out our contributors guide useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.

@netlify
Copy link

netlify bot commented Apr 3, 2025

Deploy Preview for asyncapi-website ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 491f4a9
🔍 Latest deploy log https://app.netlify.com/sites/asyncapi-website/deploys/67f253f423a96e00080c7d00
😎 Deploy Preview https://deploy-preview-4013--asyncapi-website.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@codecov
Copy link

codecov bot commented Apr 3, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (1a80ecf) to head (491f4a9).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##            master     #4013   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           21        21           
  Lines          667       667           
  Branches       113       113           
=========================================
  Hits           667       667           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@sagarkori143
Copy link
Contributor

Hey @Priyadharshini0101 Could you please center the arrow as well in this PR itself.
image

@Priyadharshini0101
Copy link
Contributor Author

Hello! I've centered the arrows as requested. Let me know if any further adjustments are needed. Thanks!

@TRohit20 TRohit20 changed the title [BUG] Banner Overlapping with Navbar fix: banner overlapping with Navbar Apr 3, 2025
TRohit20
TRohit20 previously approved these changes Apr 3, 2025
Copy link
Collaborator

@TRohit20 TRohit20 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

CC @vishvamsinh28 double check and approve if all good for merge.

@vishvamsinh28
Copy link
Contributor

@Priyadharshini0101 @TRohit20 LGTM!

@sambhavgupta0705
Copy link
Member

sambhavgupta0705 commented Apr 6, 2025

@Priyadharshini0101
image

it is not in center

Copy link
Member

@sambhavgupta0705 sambhavgupta0705 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Merging ✅

@sambhavgupta0705
Copy link
Member

/rtm

@asyncapi-bot asyncapi-bot merged commit 6a556af into asyncapi:master Apr 6, 2025
21 of 22 checks passed
@sambhavgupta0705
Copy link
Member

Thanks @Priyadharshini0101 for this contribution

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] Banner Overlapping with Navbar

6 participants