-
-
Notifications
You must be signed in to change notification settings - Fork 997
docs(community): update latest tsc members list #3959
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(community): update latest tsc members list #3959
Conversation
WalkthroughThe pull request adds a new ambassador entry for Laurent Broudoux in the Changes
Possibly related PRs
Suggested labels
Suggested reviewers
Poem
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
❌ Deploy Preview for asyncapi-website failed.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3959 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 21 21
Lines 667 667
Branches 113 113
=========================================
Hits 667 667 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
config/AMBASSADORS_MEMBERS.json (1)
584-648: New Ambassador Entry for Laurent Broudoux is Well IntegratedThe new entry for Laurent Broudoux is formatted consistently with existing ambassador objects. It correctly includes all the standard fields—such as
name,github,country,bio,company,title,img—and an array ofcontributionsthat follow the same schema as prior entries.A couple of points to consider:
- Verify that the omission of the
"link"field in the first two contribution objects is intentional. If available, adding a URL (or anullvalue if that’s preferred by your JSON schema) might help maintain consistency.- If not already in place, consider introducing a JSON schema validation to ensure all ambassador entries conform to the expected structure.
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
config/AMBASSADORS_MEMBERS.json(1 hunks)
⏰ Context from checks skipped due to timeout of 180000ms (2)
- GitHub Check: Automerge PR autoapproved by a bot
- GitHub Check: Lighthouse CI
|
what did I miss here @derberg 😥 |
|
@thulieblack something is wrong with data provided by Laurent. We need to close this PR and you need to have a look at data that he provided, the ambassador experience, in community repo, maybe some errors there? |
Updated Ambassadors list is available and this PR introduces changes with latest information about Ambassadors list
Summary by CodeRabbit