Added German Language #3886
Added German Language #3886
Conversation
Aditya90456
requested review from
Mayaleeeee,
TRohit20,
akshatnema,
anshgoyalevil,
asyncapi-bot-eve,
derberg and
quetzalliwrites
as code owners
WalkthroughThis pull request updates the multilingual configuration by extending language support to French and a new entry for Germany. The changes include updates to i18n configuration files and the translation folder structure, along with refactoring of several icon components (GitHub and LinkedIn) to accept dynamic props. Additionally, social media links in ambassador profile pages have been enhanced with conditionally rendered icons sourced from the newly added dependencies in the package file. Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant AmbassadorPage
participant IconLibrary as "lucide-react"
User->>AmbassadorPage: Request ambassador profile
AmbassadorPage->>AmbassadorPage: Verify available social media URLs
alt URL exists
AmbassadorPage->>IconLibrary: Import icon components
IconLibrary-->>AmbassadorPage: Return SVG icon
else URL missing
AmbassadorPage->>AmbassadorPage: Skip icon rendering
end
AmbassadorPage-->>User: Render profile with social links
Possibly related PRs
Suggested labels
Suggested reviewers
Poem
Tip ⚡🧪 Multi-step agentic review comment chat (experimental)
✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
❌ Deploy Preview for asyncapi-website failed.Built without sensitive environment variables
|
|
We require all PRs to follow Conventional Commits specification. |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 10
🧹 Nitpick comments (3)
next-i18next.config.cjs (1)
9-10: Remove extra whitespaceThere are unnecessary empty lines here that should be removed to maintain code style consistency.
defaultLocale: 'en', - - namespaces: ['landing-page', 'common', 'tools'],🧰 Tools
🪛 ESLint
[error] 9-10: Delete
⏎····(prettier/prettier)
pages/community/ambassadors/[id].tsx (2)
103-103: Remove unnecessary whitespaceThere's trailing whitespace that should be removed.
- +🧰 Tools
🪛 ESLint
[error] 103-103: Trailing spaces not allowed.
(no-trailing-spaces)
[error] 103-103: Delete
············(prettier/prettier)
111-111: Missing className for GitHub iconThe GitHub icon is missing the 'fill-white' className that was present in the Twitter icon and LinkedIn icon. For consistency, it should be added back.
- <IconGithub/> + <IconGithub className='fill-white' />🧰 Tools
🪛 ESLint
[error] 111-111: Insert
·(prettier/prettier)
🪛 GitHub Actions: PR testing - if Node project
[error] 89-111: Trailing spaces not allowed. (no-trailing-spaces) and various Prettier formatting issues.
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
package-lock.jsonis excluded by!**/package-lock.json
📒 Files selected for processing (8)
ADDING_TRANSLATIONS.md(2 hunks)components/icons/Github.tsx(1 hunks)components/icons/IconLinkedInProp.tsx(1 hunks)components/icons/LinkedIn.tsx(1 hunks)next-i18next.config.cjs(1 hunks)package.json(2 hunks)pages/community/ambassadors/[id].tsx(1 hunks)pages/community/ambassadors/index.tsx(2 hunks)
🧰 Additional context used
🪛 ESLint
components/icons/IconLinkedInProp.tsx
[error] 6-6: Replace "text-blue-600" with 'text-blue-600'
(prettier/prettier)
[error] 6-6: Unexpected usage of doublequote.
(jsx-quotes)
pages/community/ambassadors/index.tsx
[error] 145-145: Insert ················
(prettier/prettier)
[error] 146-146: Replace <a·href={ambassador.twitterUrl}·target='_blank'·rel='noreferrer'·className='underline·flex·items-center·gap-1' with ················<a⏎······················href={ambassador.twitterUrl}⏎······················target='_blank'⏎······················rel='noreferrer'⏎······················className='underline·flex·items-center·gap-1'⏎····················
(prettier/prettier)
[error] 147-147: Insert ················
(prettier/prettier)
[error] 148-148: Insert ················
(prettier/prettier)
[error] 149-149: Insert ················
(prettier/prettier)
[error] 150-150: Insert ················
(prettier/prettier)
[error] 151-151: Insert ················
(prettier/prettier)
[error] 152-152: Replace <a·href={ambassador.githubUrl}·target='_blank'·rel='noreferrer'·className='ml-3·underline·flex·items-center·gap-1' with ················<a⏎······················href={ambassador.githubUrl}⏎······················target='_blank'⏎······················rel='noreferrer'⏎······················className='ml-3·underline·flex·items-center·gap-1'⏎····················
(prettier/prettier)
[error] 153-153: Insert ················
(prettier/prettier)
[error] 154-154: Insert ················
(prettier/prettier)
[error] 155-155: Insert ················
(prettier/prettier)
[error] 156-156: Insert ················
(prettier/prettier)
[error] 157-157: Insert ················
(prettier/prettier)
[error] 158-158: Replace <a·href={ambassador.linkedinUrl}·target='_blank'·rel='noreferrer'·className='ml-3·underline·flex·items-center·gap-1' with ················<a⏎······················href={ambassador.linkedinUrl}⏎······················target='_blank'⏎······················rel='noreferrer'⏎······················className='ml-3·underline·flex·items-center·gap-1'⏎····················
(prettier/prettier)
[error] 159-159: Insert ················
(prettier/prettier)
[error] 160-160: Insert ················
(prettier/prettier)
[error] 161-161: Insert ················
(prettier/prettier)
[error] 162-162: Insert ················
(prettier/prettier)
[error] 163-165: Replace </div>⏎⏎ with ················</div>
(prettier/prettier)
pages/community/ambassadors/[id].tsx
[error] 89-89: Trailing spaces not allowed.
(no-trailing-spaces)
[error] 89-89: Delete ·
(prettier/prettier)
[error] 90-90: Trailing spaces not allowed.
(no-trailing-spaces)
[error] 90-90: Delete ················
(prettier/prettier)
[error] 91-91: Replace ··································<div·style={{·display:·"flex",·alignItems:·"center",·gap:·"20px" with ················<div·style={{·display:·'flex',·alignItems:·'center',·gap:·'20px'
(prettier/prettier)
[error] 91-91: Strings must use singlequote.
(quotes)
[error] 91-91: Strings must use singlequote.
(quotes)
[error] 91-91: Strings must use singlequote.
(quotes)
[error] 92-92: Replace ······················<a·href="https://www.linkedin.com/in/yourprofile"·target="_blank"·rel="noopener·noreferrer" with ··················<a·href='https://www.linkedin.com/in/yourprofile'·target='_blank'·rel='noopener·noreferrer'
(prettier/prettier)
[error] 92-92: Unexpected usage of doublequote.
(jsx-quotes)
[error] 92-92: Unexpected usage of doublequote.
(jsx-quotes)
[error] 92-92: Unexpected usage of doublequote.
(jsx-quotes)
[error] 93-93: Replace ························<IconLinkedIn·size={40}·color="#0077B5" with ····················<IconLinkedIn·size={40}·color='#0077B5'
(prettier/prettier)
[error] 93-93: Unexpected usage of doublequote.
(jsx-quotes)
[error] 94-94: Delete ····
(prettier/prettier)
[error] 95-95: Replace ······················<a·href="https://github.com/yourgithub"·target="_blank"·rel="noopener·noreferrer" with ··················<a·href='https://github.com/yourgithub'·target='_blank'·rel='noopener·noreferrer'
(prettier/prettier)
[error] 95-95: Unexpected usage of doublequote.
(jsx-quotes)
[error] 95-95: Unexpected usage of doublequote.
(jsx-quotes)
[error] 95-95: Unexpected usage of doublequote.
(jsx-quotes)
[error] 96-96: Replace ························<IconGithub with ····················<IconGithub·
(prettier/prettier)
[error] 97-97: Delete ····
(prettier/prettier)
[error] 98-100: Replace ⏎····················</div>·⏎················· with ················</div>
(prettier/prettier)
[error] 99-99: Trailing spaces not allowed.
(no-trailing-spaces)
[error] 100-100: Trailing spaces not allowed.
(no-trailing-spaces)
[error] 103-103: Trailing spaces not allowed.
(no-trailing-spaces)
[error] 103-103: Delete ············
(prettier/prettier)
[error] 111-111: Insert ·
(prettier/prettier)
components/icons/Github.tsx
[error] 1-1: Replace "black" with 'black'
(prettier/prettier)
[error] 1-1: Strings must use singlequote.
(quotes)
[error] 2-8: Replace ⏎····width={size}⏎····height={size}⏎····viewBox="0·0·24·24"⏎····fill={color}⏎····xmlns="http://www.w3.org/2000/svg"⏎·· with ·width={size}·height={size}·viewBox='0·0·24·24'·fill={color}·xmlns='http://www.w3.org/2000/svg'
(prettier/prettier)
[error] 5-5: Unexpected usage of doublequote.
(jsx-quotes)
[error] 7-7: Unexpected usage of doublequote.
(jsx-quotes)
[error] 9-9: Replace "M12·.297c-6.63·0-12·5.373-12·12·0·5.303..." with 'M12·.297c-6.63·0-12·5.373-12·12·0·5.303...'
(prettier/prettier)
[error] 9-9: Unexpected usage of doublequote.
(jsx-quotes)
next-i18next.config.cjs
[error] 7-7: Insert ·
(prettier/prettier)
[error] 9-10: Delete ⏎····
(prettier/prettier)
[error] 18-18: Insert ·
(prettier/prettier)
components/icons/LinkedIn.tsx
[error] 1-1: Replace "react" with 'react'
(prettier/prettier)
[error] 1-1: Strings must use singlequote.
(quotes)
[error] 9-13: Replace ⏎··className·=·"",⏎··size·=·24,⏎··color·=·"currentColor",⏎ with ·className·=·'',·size·=·24,·color·=·'currentColor'·
(prettier/prettier)
[error] 10-10: Strings must use singlequote.
(quotes)
[error] 12-12: Strings must use singlequote.
(quotes)
[error] 12-12: Unexpected trailing comma.
(comma-dangle)
[error] 19-19: Replace "0·0·24·24" with '0·0·24·24'
(prettier/prettier)
[error] 19-19: Unexpected usage of doublequote.
(jsx-quotes)
[error] 21-21: Replace "http://www.w3.org/2000/svg" with 'http://www.w3.org/2000/svg'
(prettier/prettier)
[error] 21-21: Unexpected usage of doublequote.
(jsx-quotes)
[error] 23-23: Replace "M4.98·3.5c0·1.38-1.12·2.5-2.5·2.5S0·4.88·0·3.5·1.12·1·2.5·1s2.48·1.12·2.48·2.5zM.5·22h4V7h-4v15zM7.5·7h3.75v2.03h.05c.52-.99·1.8-2.03·3.7-2.03·3.96·0·4.7·2.6·4.7·5.98V22h-4v-7.22c0-1.72-.03-3.94-2.4-3.94-2.4·0-2.77·1.87-2.77·3.8V22h-4V7z" with 'M4.98·3.5c0·1.38-1.12·2.5-2.5·2.5S0·4.88·0·3.5·1.12·1·2.5·1s2.48·1.12·2.48·2.5zM.5·22h4V7h-4v15zM7.5·7h3.75v2.03h.05c.52-.99·1.8-2.03·3.7-2.03·3.96·0·4.7·2.6·4.7·5.98V22h-4v-7.22c0-1.72-.03-3.94-2.4-3.94-2.4·0-2.77·1.87-2.77·3.8V22h-4V7z'
(prettier/prettier)
[error] 23-23: Unexpected usage of doublequote.
(jsx-quotes)
🪛 GitHub Actions: PR testing - if Node project
components/icons/IconLinkedInProp.tsx
[error] 3-6: Replace double quotes with single quotes. (prettier/prettier)
pages/community/ambassadors/index.tsx
[error] 1-165: Run autofix to sort these imports! (simple-import-sort/imports) and various Prettier formatting issues.
pages/community/ambassadors/[id].tsx
[error] 89-111: Trailing spaces not allowed. (no-trailing-spaces) and various Prettier formatting issues.
components/icons/Github.tsx
[error] 1-9: Strings must use singlequote. (quotes) and various Prettier formatting issues.
components/icons/LinkedIn.tsx
[error] 1-23: Strings must use singlequote. (quotes) and various Prettier formatting issues.
⏰ Context from checks skipped due to timeout of 180000ms (1)
- GitHub Check: Lighthouse CI
🔇 Additional comments (4)
package.json (2)
102-102:❌ Incorrect review comment
Potentially incorrect package name
You've added "react-icon" (singular), but the more commonly used package is "react-icons" (plural). This might be a typo or confusion between packages.
🏁 Script executed:
#!/bin/bash # Description: Check if react-icon is being used and if react-icons might be more appropriate echo "Checking for imports from react-icon..." rg -l "from\s+'react-icon'" --type ts --type tsx echo "Checking if react-icons package exists on npm..." npm view react-icons --json | jq '.name, .description' echo "Checking if react-icon package exists on npm..." npm view react-icon --json | jq '.name, .description'Length of output: 610
Confirm Package Name Usage
After verification, both the "react-icon" and "react-icons" packages exist on npm. The dependency in your package.json uses "react-icon" (version ^1.0.0), which is valid and corresponds to its description ("Icon component for React"). If your intention was indeed to use "react-icon," then no correction is needed. However, if you meant to use the more commonly adopted "react-icons" package (providing SVG React icons from popular icon packs), you'll need to update the dependency and corresponding imports accordingly.
- Action: Verify that your code’s import statements match the intended package (either "react-icon" or "react-icons").
- If using react-icons: Update the dependency in package.json and adjust any related code.
Likely an incorrect or invalid review comment.
84-84:✅ Verification successful
Verify usage of lucide-react library
The addition of the lucide-react library appears to be for icon components. Make sure this library is actually being used in the codebase.
🏁 Script executed:
#!/bin/bash # Description: Check for usage of lucide-react in the codebase echo "Checking for imports from lucide-react..." rg -l "from\s+'lucide-react'" --type ts --type tsxLength of output: 179
Below is a revised script to further verify that the lucide-react library is in use. The previous command failed due to an unrecognized tsx file type, so this updated script explicitly searches in both *.ts and *.tsx files:
Please execute this script and examine the output. If lucide-react usage is found, confirm its relevance; if not, consider whether the dependency is necessary or if it can be removed.
🏁 Script executed:
#!/bin/bash # Description: Re-verify usage of lucide-react in the codebase by explicitly searching .ts and .tsx files echo "Searching for lucide-react usage in .ts and .tsx files..." rg -l "lucide-react" --glob "*.ts" --glob "*.tsx"Length of output: 334
Lucide-react usage confirmed in pages/community/ambassadors/index.tsx
The lucide-react dependency added in package.json is actively used for icon components. Our updated search located an import in pages/community/ambassadors/index.tsx. No further changes are required.
pages/community/ambassadors/index.tsx (1)
4-4: Properly import and use the social media icons.Good addition of the Lucide React icons to enhance the UI. This makes the social media links more visually recognizable.
components/icons/Github.tsx (1)
1-13:❓ Verification inconclusive
Fix string quotes and use consistent component naming.
The component refactoring to accept props is good, but there are some issues to address:
- Use single quotes instead of double quotes to comply with the project's style
- Ensure component naming is consistent (note the capitalization of "GitHub" vs. "Github")
Apply this diff:
-const IconGitHub = ({ size = 24, color = "black" }) => ( - <svg - width={size} - height={size} - viewBox="0 0 24 24" - fill={color} - xmlns="http://www.w3.org/2000/svg" - > - <path d="M12 .297c-6.63 0-12 5.373-12 12 0 5.303..." /> - </svg> -); +const IconGitHub = ({ size = 24, color = 'black' }) => ( + <svg width={size} height={size} viewBox='0 0 24 24' fill={color} xmlns='http://www.w3.org/2000/svg'> + <path d='M12 .297c-6.63 0-12 5.373-12 12 0 5.303...' /> + </svg> +);I recommend validating this component name change across the codebase to ensure it won't break existing usage.
🏁 Script executed:
#!/bin/bash # Search for any instances of the old 'IconGithub' (lowercase 'h') usage rg "IconGithub" --type tsx --type tsLength of output: 64
Below is an updated review comment that reflects the changes while flagging the need for manual verification of the component name usage:
Update: Unify Quotes and Component Naming For Consistency
The refactoring now uses single quotes and properly capitalizes the component name ("IconGitHub"). However, due to issues with file-type recognition in our automated search, please manually verify that there are no lingering instances of the outdated name ("IconGithub") elsewhere in the codebase.
Changes applied:
- Converted all double quotes to single quotes.
- Ensured that the component maintains a consistent name ("IconGitHub").
-const IconGitHub = ({ size = 24, color = "black" }) => ( - <svg - width={size} - height={size} - viewBox="0 0 24 24" - fill={color} - xmlns="http://www.w3.org/2000/svg" - > - <path d="M12 .297c-6.63 0-12 5.373-12 12 0 5.303..." /> - </svg> -); +const IconGitHub = ({ size = 24, color = 'black' }) => ( + <svg width={size} height={size} viewBox='0 0 24 24' fill={color} xmlns='http://www.w3.org/2000/svg'> + <path d='M12 .297c-6.63 0-12 5.373-12 12 0 5.303...' /> + </svg> +);Action Required:
• Manual verification – Please confirm that no usage of the old name ("IconGithub" with a lowercase “h”) exists in any.tsor.tsxfiles since the original automated search encountered file-type issues.🧰 Tools
🪛 ESLint
[error] 1-1: Replace
"black"with'black'(prettier/prettier)
[error] 1-1: Strings must use singlequote.
(quotes)
[error] 2-8: Replace
⏎····width={size}⏎····height={size}⏎····viewBox="0·0·24·24"⏎····fill={color}⏎····xmlns="http://www.w3.org/2000/svg"⏎··with·width={size}·height={size}·viewBox='0·0·24·24'·fill={color}·xmlns='http://www.w3.org/2000/svg'(prettier/prettier)
[error] 5-5: Unexpected usage of doublequote.
(jsx-quotes)
[error] 7-7: Unexpected usage of doublequote.
(jsx-quotes)
[error] 9-9: Replace
"M12·.297c-6.63·0-12·5.373-12·12·0·5.303..."with'M12·.297c-6.63·0-12·5.373-12·12·0·5.303...'(prettier/prettier)
[error] 9-9: Unexpected usage of doublequote.
(jsx-quotes)
🪛 GitHub Actions: PR testing - if Node project
[error] 1-9: Strings must use singlequote. (quotes) and various Prettier formatting issues.
| module.exports = { | ||
| i18n: { | ||
| locales: ['en', 'de'], | ||
| locales: ['en', 'de','ge'], |
There was a problem hiding this comment.
Incorrect language code for German
The ISO language code for German is 'de' (which is already in your locales array). The code 'ge' is typically used for Georgia, not Germany. This will cause problems with localization.
- locales: ['en', 'de','ge'],
+ locales: ['en', 'de'],📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| locales: ['en', 'de','ge'], | |
| locales: ['en', 'de'], |
🧰 Tools
🪛 ESLint
[error] 7-7: Insert ·
(prettier/prettier)
| de: 'Deutsch', | ||
| ge:'German' |
There was a problem hiding this comment.
Inconsistent language naming in langMap
There's inconsistency in language naming conventions. 'de' maps to 'Deutsch' (German name in German) while 'ge' maps to 'German' (German name in English). Additionally, 'ge' is not the correct language code for German.
en: 'English',
- de: 'Deutsch',
- ge:'German'
+ de: 'Deutsch'If you're intending to add German translation support, it's already present with the 'de' code.
📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| de: 'Deutsch', | |
| ge:'German' | |
| en: 'English', | |
| de: 'Deutsch' |
🧰 Tools
🪛 ESLint
[error] 18-18: Insert ·
(prettier/prettier)
| export default function Home() { | ||
| return ( | ||
| <div> | ||
| <IconLinkedIn className="text-blue-600" size={32} /> | ||
| </div> | ||
| ); | ||
| } |
There was a problem hiding this comment.
🛠️ Refactor suggestion
Component name doesn't match file purpose
The component is named 'Home' which doesn't reflect its purpose or match the file name 'IconLinkedInProp'. Also, the component is just wrapping the LinkedIn icon without adding meaningful functionality.
-export default function Home() {
+export default function IconLinkedInProp() {
return (
<div>
- <IconLinkedIn className="text-blue-600" size={32} />
+ <IconLinkedIn className='text-blue-600' size={32} />
</div>
);
}Consider if this wrapper component is necessary at all, or if you should directly use the IconLinkedIn component where needed.
📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| export default function Home() { | |
| return ( | |
| <div> | |
| <IconLinkedIn className="text-blue-600" size={32} /> | |
| </div> | |
| ); | |
| } | |
| export default function IconLinkedInProp() { | |
| return ( | |
| <div> | |
| <IconLinkedIn className='text-blue-600' size={32} /> | |
| </div> | |
| ); | |
| } |
🧰 Tools
🪛 ESLint
[error] 6-6: Replace "text-blue-600" with 'text-blue-600'
(prettier/prettier)
[error] 6-6: Unexpected usage of doublequote.
(jsx-quotes)
🪛 GitHub Actions: PR testing - if Node project
[error] 3-6: Replace double quotes with single quotes. (prettier/prettier)
| <IconTwitter className='fill-white' /> | ||
|
|
||
| <div style={{ display: "flex", alignItems: "center", gap: "20px" }}> | ||
| <a href="https://www.linkedin.com/in/yourprofile" target="_blank" rel="noopener noreferrer"> | ||
| <IconLinkedIn size={40} color="#0077B5" /> | ||
| </a> | ||
| <a href="https://github.com/yourgithub" target="_blank" rel="noopener noreferrer"> | ||
| <IconGithub/> | ||
| </a> | ||
|
|
||
| </div> | ||
|
|
||
| </div> |
There was a problem hiding this comment.
Problematic social media link structure
There are several critical issues with this implementation:
- You're nesting LinkedIn and GitHub links inside the Twitter icon/button, which breaks UI functionality and creates confusing UX
- Using hardcoded URLs instead of the ambassador's data
- Using inline styles rather than Tailwind classes
- Duplicating social links that already exist below
This implementation should be removed entirely as proper social links already exist in lines 104-124. If you intended to add additional social links, they should be implemented in a similar style to the existing ones.
- <IconTwitter className='fill-white' />
-
- <div style={{ display: "flex", alignItems: "center", gap: "20px" }}>
- <a href="https://www.linkedin.com/in/yourprofile" target="_blank" rel="noopener noreferrer">
- <IconLinkedIn size={40} color="#0077B5" />
- </a>
- <a href="https://github.com/yourgithub" target="_blank" rel="noopener noreferrer">
- <IconGithub/>
- </a>
-
- </div>
-
+ <IconTwitter className='fill-white' />📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| <IconTwitter className='fill-white' /> | |
| <div style={{ display: "flex", alignItems: "center", gap: "20px" }}> | |
| <a href="https://www.linkedin.com/in/yourprofile" target="_blank" rel="noopener noreferrer"> | |
| <IconLinkedIn size={40} color="#0077B5" /> | |
| </a> | |
| <a href="https://github.com/yourgithub" target="_blank" rel="noopener noreferrer"> | |
| <IconGithub/> | |
| </a> | |
| </div> | |
| </div> | |
| <IconTwitter className='fill-white' /> | |
| </div> |
🧰 Tools
🪛 ESLint
[error] 89-89: Trailing spaces not allowed.
(no-trailing-spaces)
[error] 89-89: Delete ·
(prettier/prettier)
[error] 90-90: Trailing spaces not allowed.
(no-trailing-spaces)
[error] 90-90: Delete ················
(prettier/prettier)
[error] 91-91: Replace ··································<div·style={{·display:·"flex",·alignItems:·"center",·gap:·"20px" with ················<div·style={{·display:·'flex',·alignItems:·'center',·gap:·'20px'
(prettier/prettier)
[error] 91-91: Strings must use singlequote.
(quotes)
[error] 91-91: Strings must use singlequote.
(quotes)
[error] 91-91: Strings must use singlequote.
(quotes)
[error] 92-92: Replace ······················<a·href="https://www.linkedin.com/in/yourprofile"·target="_blank"·rel="noopener·noreferrer" with ··················<a·href='https://www.linkedin.com/in/yourprofile'·target='_blank'·rel='noopener·noreferrer'
(prettier/prettier)
[error] 92-92: Unexpected usage of doublequote.
(jsx-quotes)
[error] 92-92: Unexpected usage of doublequote.
(jsx-quotes)
[error] 92-92: Unexpected usage of doublequote.
(jsx-quotes)
[error] 93-93: Replace ························<IconLinkedIn·size={40}·color="#0077B5" with ····················<IconLinkedIn·size={40}·color='#0077B5'
(prettier/prettier)
[error] 93-93: Unexpected usage of doublequote.
(jsx-quotes)
[error] 94-94: Delete ····
(prettier/prettier)
[error] 95-95: Replace ······················<a·href="https://github.com/yourgithub"·target="_blank"·rel="noopener·noreferrer" with ··················<a·href='https://github.com/yourgithub'·target='_blank'·rel='noopener·noreferrer'
(prettier/prettier)
[error] 95-95: Unexpected usage of doublequote.
(jsx-quotes)
[error] 95-95: Unexpected usage of doublequote.
(jsx-quotes)
[error] 95-95: Unexpected usage of doublequote.
(jsx-quotes)
[error] 96-96: Replace ························<IconGithub with ····················<IconGithub·
(prettier/prettier)
[error] 97-97: Delete ····
(prettier/prettier)
[error] 98-100: Replace ⏎····················</div>·⏎················· with ················</div>
(prettier/prettier)
[error] 99-99: Trailing spaces not allowed.
(no-trailing-spaces)
[error] 100-100: Trailing spaces not allowed.
(no-trailing-spaces)
🪛 GitHub Actions: PR testing - if Node project
[error] 89-111: Trailing spaces not allowed. (no-trailing-spaces) and various Prettier formatting issues.
| {ambassador.twitterUrl && ( | ||
| <a href={ambassador.twitterUrl} target='_blank' rel='noreferrer' className='underline flex items-center gap-1'> | ||
| <Twitter size={16} className='text-blue-400' /> | ||
| </a> | ||
| )} | ||
| {ambassador.githubUrl && ( | ||
| <a href={ambassador.githubUrl} target='_blank' rel='noreferrer' className='ml-3 underline flex items-center gap-1'> | ||
| <Github size={16} className='text-gray-700' /> | ||
| Github | ||
| </a> | ||
| )} | ||
| {ambassador.linkedinUrl && ( | ||
| <a href={ambassador.linkedinUrl} target='_blank' rel='noreferrer' className='ml-3 underline flex items-center gap-1'> | ||
| <Linkedin size={16} className='text-blue-600' /> | ||
| </a> | ||
| )} |
There was a problem hiding this comment.
Fix the indentation and formatting issues.
The social media links implementation with conditional rendering and icons looks good, but there are formatting issues that need to be addressed to pass the pipeline checks.
Apply this diff to fix the formatting:
- {ambassador.twitterUrl && (
- <a href={ambassador.twitterUrl} target='_blank' rel='noreferrer' className='underline flex items-center gap-1'>
- <Twitter size={16} className='text-blue-400' />
- Twitter
- </a>
- )}
- {ambassador.githubUrl && (
- <a href={ambassador.githubUrl} target='_blank' rel='noreferrer' className='ml-3 underline flex items-center gap-1'>
- <Github size={16} className='text-gray-700' />
- Github
- </a>
- )}
- {ambassador.linkedinUrl && (
- <a href={ambassador.linkedinUrl} target='_blank' rel='noreferrer' className='ml-3 underline flex items-center gap-1'>
- <Linkedin size={16} className='text-blue-600' />
- Linkedin
- </a>
- )}
+ {ambassador.twitterUrl && (
+ <a
+ href={ambassador.twitterUrl}
+ target='_blank'
+ rel='noreferrer'
+ className='underline flex items-center gap-1'
+ >
+ <Twitter size={16} className='text-blue-400' />
+ Twitter
+ </a>
+ )}
+ {ambassador.githubUrl && (
+ <a
+ href={ambassador.githubUrl}
+ target='_blank'
+ rel='noreferrer'
+ className='ml-3 underline flex items-center gap-1'
+ >
+ <Github size={16} className='text-gray-700' />
+ Github
+ </a>
+ )}
+ {ambassador.linkedinUrl && (
+ <a
+ href={ambassador.linkedinUrl}
+ target='_blank'
+ rel='noreferrer'
+ className='ml-3 underline flex items-center gap-1'
+ >
+ <Linkedin size={16} className='text-blue-600' />
+ Linkedin
+ </a>
+ )}📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| {ambassador.twitterUrl && ( | |
| <a href={ambassador.twitterUrl} target='_blank' rel='noreferrer' className='underline flex items-center gap-1'> | |
| <Twitter size={16} className='text-blue-400' /> | |
| </a> | |
| )} | |
| {ambassador.githubUrl && ( | |
| <a href={ambassador.githubUrl} target='_blank' rel='noreferrer' className='ml-3 underline flex items-center gap-1'> | |
| <Github size={16} className='text-gray-700' /> | |
| Github | |
| </a> | |
| )} | |
| {ambassador.linkedinUrl && ( | |
| <a href={ambassador.linkedinUrl} target='_blank' rel='noreferrer' className='ml-3 underline flex items-center gap-1'> | |
| <Linkedin size={16} className='text-blue-600' /> | |
| </a> | |
| )} | |
| {ambassador.twitterUrl && ( | |
| <a | |
| href={ambassador.twitterUrl} | |
| target='_blank' | |
| rel='noreferrer' | |
| className='underline flex items-center gap-1' | |
| > | |
| <Twitter size={16} className='text-blue-400' /> | |
| </a> | |
| )} | |
| {ambassador.githubUrl && ( | |
| <a | |
| href={ambassador.githubUrl} | |
| target='_blank' | |
| rel='noreferrer' | |
| className='ml-3 underline flex items-center gap-1' | |
| > | |
| <Github size={16} className='text-gray-700' /> | |
| Github | |
| </a> | |
| )} | |
| {ambassador.linkedinUrl && ( | |
| <a | |
| href={ambassador.linkedinUrl} | |
| target='_blank' | |
| rel='noreferrer' | |
| className='ml-3 underline flex items-center gap-1' | |
| > | |
| <Linkedin size={16} className='text-blue-600' /> | |
| </a> | |
| )} |
🧰 Tools
🪛 ESLint
[error] 145-145: Insert ················
(prettier/prettier)
[error] 146-146: Replace <a·href={ambassador.twitterUrl}·target='_blank'·rel='noreferrer'·className='underline·flex·items-center·gap-1' with ················<a⏎······················href={ambassador.twitterUrl}⏎······················target='_blank'⏎······················rel='noreferrer'⏎······················className='underline·flex·items-center·gap-1'⏎····················
(prettier/prettier)
[error] 147-147: Insert ················
(prettier/prettier)
[error] 148-148: Insert ················
(prettier/prettier)
[error] 149-149: Insert ················
(prettier/prettier)
[error] 150-150: Insert ················
(prettier/prettier)
[error] 151-151: Insert ················
(prettier/prettier)
[error] 152-152: Replace <a·href={ambassador.githubUrl}·target='_blank'·rel='noreferrer'·className='ml-3·underline·flex·items-center·gap-1' with ················<a⏎······················href={ambassador.githubUrl}⏎······················target='_blank'⏎······················rel='noreferrer'⏎······················className='ml-3·underline·flex·items-center·gap-1'⏎····················
(prettier/prettier)
[error] 153-153: Insert ················
(prettier/prettier)
[error] 154-154: Insert ················
(prettier/prettier)
[error] 155-155: Insert ················
(prettier/prettier)
[error] 156-156: Insert ················
(prettier/prettier)
[error] 157-157: Insert ················
(prettier/prettier)
[error] 158-158: Replace <a·href={ambassador.linkedinUrl}·target='_blank'·rel='noreferrer'·className='ml-3·underline·flex·items-center·gap-1' with ················<a⏎······················href={ambassador.linkedinUrl}⏎······················target='_blank'⏎······················rel='noreferrer'⏎······················className='ml-3·underline·flex·items-center·gap-1'⏎····················
(prettier/prettier)
[error] 159-159: Insert ················
(prettier/prettier)
[error] 160-160: Insert ················
(prettier/prettier)
[error] 161-161: Insert ················
(prettier/prettier)
[error] 162-162: Insert ················
(prettier/prettier)
| import React from "react"; | ||
|
|
||
| /* eslint-disable max-len */ | ||
| /** | ||
| * @description Icons for asyncapi website | ||
| */ | ||
| export default function IconLinkedIn({ className = '' }) { | ||
| interface IconLinkedInProps { | ||
| className?: string; | ||
| size?: number; | ||
| color?: string; | ||
| } |
There was a problem hiding this comment.
🛠️ Refactor suggestion
Fix string quotes and use consistent quotes throughout the file.
The TypeScript interface addition is good, but string quoting needs to be fixed to comply with project standards.
Apply this diff:
-import React from "react";
+import React from 'react';
interface IconLinkedInProps {
className?: string;
size?: number;
color?: string;
}📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| import React from "react"; | |
| /* eslint-disable max-len */ | |
| /** | |
| * @description Icons for asyncapi website | |
| */ | |
| export default function IconLinkedIn({ className = '' }) { | |
| interface IconLinkedInProps { | |
| className?: string; | |
| size?: number; | |
| color?: string; | |
| } | |
| import React from 'react'; | |
| interface IconLinkedInProps { | |
| className?: string; | |
| size?: number; | |
| color?: string; | |
| } |
🧰 Tools
🪛 ESLint
[error] 1-1: Replace "react" with 'react'
(prettier/prettier)
[error] 1-1: Strings must use singlequote.
(quotes)
🪛 GitHub Actions: PR testing - if Node project
[error] 1-23: Strings must use singlequote. (quotes) and various Prettier formatting issues.
| className = "", | ||
| size = 24, | ||
| color = "currentColor", | ||
| }) => { | ||
| return ( |
There was a problem hiding this comment.
🛠️ Refactor suggestion
Fix formatting issues and remove trailing comma.
Apply this diff to address the formatting:
-const IconLinkedIn: React.FC<IconLinkedInProps> = ({
- className = "",
- size = 24,
- color = "currentColor",
-}) => {
+const IconLinkedIn: React.FC<IconLinkedInProps> = ({ className = '', size = 24, color = 'currentColor' }) => {📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| const IconLinkedIn: React.FC<IconLinkedInProps> = ({ | |
| className = "", | |
| size = 24, | |
| color = "currentColor", | |
| }) => { | |
| const IconLinkedIn: React.FC<IconLinkedInProps> = ({ className = '', size = 24, color = 'currentColor' }) => { |
🧰 Tools
🪛 ESLint
[error] 9-13: Replace ⏎··className·=·"",⏎··size·=·24,⏎··color·=·"currentColor",⏎ with ·className·=·'',·size·=·24,·color·=·'currentColor'·
(prettier/prettier)
[error] 10-10: Strings must use singlequote.
(quotes)
[error] 12-12: Strings must use singlequote.
(quotes)
[error] 12-12: Unexpected trailing comma.
(comma-dangle)
| className={className} | ||
| width={size} | ||
| height={size} | ||
| viewBox="0 0 24 24" | ||
| fill={color} | ||
| xmlns="http://www.w3.org/2000/svg" | ||
| > | ||
| <path d="M4.98 3.5c0 1.38-1.12 2.5-2.5 2.5S0 4.88 0 3.5 1.12 1 2.5 1s2.48 1.12 2.48 2.5zM.5 22h4V7h-4v15zM7.5 7h3.75v2.03h.05c.52-.99 1.8-2.03 3.7-2.03 3.96 0 4.7 2.6 4.7 5.98V22h-4v-7.22c0-1.72-.03-3.94-2.4-3.94-2.4 0-2.77 1.87-2.77 3.8V22h-4V7z" /> | ||
| </svg> |
There was a problem hiding this comment.
🛠️ Refactor suggestion
Fix string quotes in SVG attributes.
Apply this diff to fix the quotes in SVG attributes:
<svg
className={className}
width={size}
height={size}
- viewBox="0 0 24 24"
+ viewBox='0 0 24 24'
fill={color}
- xmlns="http://www.w3.org/2000/svg"
+ xmlns='http://www.w3.org/2000/svg'
>
- <path d="M4.98 3.5c0 1.38-1.12 2.5-2.5 2.5S0 4.88 0 3.5 1.12 1 2.5 1s2.48 1.12 2.48 2.5zM.5 22h4V7h-4v15zM7.5 7h3.75v2.03h.05c.52-.99 1.8-2.03 3.7-2.03 3.96 0 4.7 2.6 4.7 5.98V22h-4v-7.22c0-1.72-.03-3.94-2.4-3.94-2.4 0-2.77 1.87-2.77 3.8V22h-4V7z" />
+ <path d='M4.98 3.5c0 1.38-1.12 2.5-2.5 2.5S0 4.88 0 3.5 1.12 1 2.5 1s2.48 1.12 2.48 2.5zM.5 22h4V7h-4v15zM7.5 7h3.75v2.03h.05c.52-.99 1.8-2.03 3.7-2.03 3.96 0 4.7 2.6 4.7 5.98V22h-4v-7.22c0-1.72-.03-3.94-2.4-3.94-2.4 0-2.77 1.87-2.77 3.8V22h-4V7z' />📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| <svg | |
| className={className} | |
| width={size} | |
| height={size} | |
| viewBox="0 0 24 24" | |
| fill={color} | |
| xmlns="http://www.w3.org/2000/svg" | |
| > | |
| <path d="M4.98 3.5c0 1.38-1.12 2.5-2.5 2.5S0 4.88 0 3.5 1.12 1 2.5 1s2.48 1.12 2.48 2.5zM.5 22h4V7h-4v15zM7.5 7h3.75v2.03h.05c.52-.99 1.8-2.03 3.7-2.03 3.96 0 4.7 2.6 4.7 5.98V22h-4v-7.22c0-1.72-.03-3.94-2.4-3.94-2.4 0-2.77 1.87-2.77 3.8V22h-4V7z" /> | |
| <svg | |
| className={className} | |
| width={size} | |
| height={size} | |
| viewBox='0 0 24 24' | |
| fill={color} | |
| xmlns='http://www.w3.org/2000/svg' | |
| > | |
| <path d='M4.98 3.5c0 1.38-1.12 2.5-2.5 2.5S0 4.88 0 3.5 1.12 1 2.5 1s2.48 1.12 2.48 2.5zM.5 22h4V7h-4v15zM7.5 7h3.75v2.03h.05c.52-.99 1.8-2.03 3.7-2.03 3.96 0 4.7 2.6 4.7 5.98V22h-4v-7.22c0-1.72-.03-3.94-2.4-3.94-2.4 0-2.77 1.87-2.77 3.8V22h-4V7z' /> |
🧰 Tools
🪛 ESLint
[error] 19-19: Replace "0·0·24·24" with '0·0·24·24'
(prettier/prettier)
[error] 19-19: Unexpected usage of doublequote.
(jsx-quotes)
[error] 21-21: Replace "http://www.w3.org/2000/svg" with 'http://www.w3.org/2000/svg'
(prettier/prettier)
[error] 21-21: Unexpected usage of doublequote.
(jsx-quotes)
[error] 23-23: Replace "M4.98·3.5c0·1.38-1.12·2.5-2.5·2.5S0·4.88·0·3.5·1.12·1·2.5·1s2.48·1.12·2.48·2.5zM.5·22h4V7h-4v15zM7.5·7h3.75v2.03h.05c.52-.99·1.8-2.03·3.7-2.03·3.96·0·4.7·2.6·4.7·5.98V22h-4v-7.22c0-1.72-.03-3.94-2.4-3.94-2.4·0-2.77·1.87-2.77·3.8V22h-4V7z" with 'M4.98·3.5c0·1.38-1.12·2.5-2.5·2.5S0·4.88·0·3.5·1.12·1·2.5·1s2.48·1.12·2.48·2.5zM.5·22h4V7h-4v15zM7.5·7h3.75v2.03h.05c.52-.99·1.8-2.03·3.7-2.03·3.96·0·4.7·2.6·4.7·5.98V22h-4v-7.22c0-1.72-.03-3.94-2.4-3.94-2.4·0-2.77·1.87-2.77·3.8V22h-4V7z'
(prettier/prettier)
[error] 23-23: Unexpected usage of doublequote.
(jsx-quotes)
🪛 GitHub Actions: PR testing - if Node project
[error] 1-23: Strings must use singlequote. (quotes) and various Prettier formatting issues.
| + languages: ["en", "de", "fr,ge"], | ||
| defaultLanguage: "en", |
There was a problem hiding this comment.
Fix the language array format - languages should be separate strings.
There's an issue with how the languages are added. The format used combines "fr,ge" as a single string, which is incorrect. Languages should be separate string elements in the array.
Apply this diff:
- languages: ["en", "de", "fr,ge"],
+ languages: ["en", "de", "fr", "ge"],📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| + languages: ["en", "de", "fr,ge"], | |
| defaultLanguage: "en", | |
| languages: ["en", "de", "fr", "ge"], | |
| defaultLanguage: "en", |
| + fr: 'French', | ||
| ge:'Germany' | ||
| }, |
There was a problem hiding this comment.
Double-check country code for Germany and fix formatting inconsistency.
There are two issues here:
- The standard country code for Germany is "de" (which is already in the list), while "ge" is typically used for Georgia. You're also using "de" for "Deutsch" above.
- The formatting is inconsistent - there's no space after the colon for 'ge'.
Please verify if you meant to add Georgia or a different language. If you meant to add German, it's already there as "de". If you meant to add Georgian, use:
fr: 'French',
- ge:'Germany'
+ ge: 'Georgian'If you meant to add German, which seems to already be present as "de", you should remove this entry or clarify its purpose.
📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| + fr: 'French', | |
| ge:'Germany' | |
| }, | |
| fr: 'French', | |
| ge: 'Georgian' | |
| }, |
|
Deutsch is a German language only |
3 participants
I added German Language
Summary by CodeRabbit
New Features
Refactor