Skip to content

feat: make scroll to top button attractive with hover effects #3605

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Jan 30, 2025
Merged

feat: make scroll to top button attractive with hover effects #3605

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
ae17c97
Make Scroll to top button attractive with Hover effects
Jan 24, 2025
db4872a
Fix linting issues
Jan 24, 2025
c85eee5
Merge branch 'master' into scroll-btn
zalabhavy Jan 24, 2025
d462f7d
Merge branch 'master' into scroll-btn
zalabhavy Jan 25, 2025
57b96c8
Merge branch 'master' into scroll-btn
zalabhavy Jan 26, 2025
d60aa1f
Merge branch 'master' into scroll-btn
zalabhavy Jan 27, 2025
7938cc2
Merge branch 'master' into scroll-btn
zalabhavy Jan 27, 2025
579803d
Merge branch 'master' into scroll-btn
zalabhavy Jan 28, 2025
a5e8835
Merge branch 'master' into scroll-btn
asyncapi-bot Jan 29, 2025
29e9056
Merge branch 'master' into scroll-btn
anshgoyalevil Jan 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion components/buttons/ScrollButton.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ function ScrollButton() {
return (
<div className='fixed bottom-14 right-4 z-40 h-16 w-12'>
{backToTopButton && (
<button className='rounded-full bg-white shadow-md ' onClick={scrollUp}>
<button className='rounded-full bg-white shadow-md hover:bg-[#8851FB] hover:scale-110 transition-all duration-300 ease-in-out' onClick={scrollUp}>
Copy link
Contributor

@coderabbitai coderabbitai bot Jan 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🛠️ Refactor suggestion

Resolve Pipeline Failures by Fixing Tailwind Class Order and Multi-line Formatting

Currently, the pipeline fails due to formatting errors and a Tailwind CSS class ordering warning. You can move the onClick prop to a new line and reorder classes to address both issues.

Apply this diff to fix the pipeline failures:

-        <button className='rounded-full bg-white shadow-md hover:bg-[#8851FB] hover:scale-110 transition-all duration-300 ease-in-out' onClick={scrollUp}>
+        <button
+          className="bg-white rounded-full shadow-md transition-all duration-300 ease-in-out hover:bg-[#8851FB] hover:scale-110"
+          onClick={scrollUp}
+        >
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
<button className='rounded-full bg-white shadow-md hover:bg-[#8851FB] hover:scale-110 transition-all duration-300 ease-in-out' onClick={scrollUp}>
<button
className="bg-white rounded-full shadow-md transition-all duration-300 ease-in-out hover:bg-[#8851FB] hover:scale-110"
onClick={scrollUp}
>
🧰 Tools
🪛 eslint

[error] 31-31: Replace ·className='rounded-full·bg-white·shadow-md·hover:bg-[#8851FB]·hover:scale-110·transition-all·duration-300·ease-in-out'·onClick={scrollUp} with ⏎··········className='rounded-full·bg-white·shadow-md·hover:bg-[#8851FB]·hover:scale-110·transition-all·duration-300·ease-in-out'⏎··········onClick={scrollUp}⏎········

(prettier/prettier)

🪛 GitHub Actions: PR testing - if Node project

[error] 31-31: Formatting error: Incorrect formatting of className and onClick props. Props should be on separate lines

[warning] 31-31: Invalid Tailwind CSS classnames order

<img src={scrollImage} alt='scroll to top' />
</button>
)}
Expand Down
Loading