chore: add Adidas and Morgan Stanley to list of adopters #3338
Conversation
derberg
requested review from
Mayaleeeee,
akshatnema,
anshgoyalevil,
asyncapi-bot-eve and
magicmatatjahu
as code owners
WalkthroughThe changes include an update to the Changes
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
✅ Deploy Preview for asyncapi-website ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3338 +/- ##
=======================================
Coverage 49.14% 49.14%
=======================================
Files 21 21
Lines 647 647
=======================================
Hits 318 318
Misses 329 329 ☔ View full report in Codecov by Sentry. |
|
⚡️ Lighthouse report for the changes in this PR:
Lighthouse ran on https://deploy-preview-3338--asyncapi-website.netlify.app/ |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
🧹 Outside diff range and nitpick comments (2)
components/sponsors/SilverSponsorsList.ts (1)
Line range hint
1-54: Consider standardizing alt text descriptions across all sponsors.While the new alt text for Bump.sh is more descriptive, there's inconsistency in alt text style across sponsors. Most sponsors use just the brand name, while Bump.sh and Route4Me have descriptive texts. Consider standardizing the approach for all sponsors to maintain consistency and improve accessibility throughout.
Example format suggestions:
- Option 1 (Brand + Description): "[Brand Name] - [Service Description]"
- Option 2 (Brand Only): Just the brand name if it's a well-known company
This would help maintain a consistent user experience for screen reader users.
config/adopters.yml (1)
85-89: Polish the use case description for better readability.The current description uses fragmented sentences. Consider rewording for better flow:
- useCase: AsyncAPI is a standard for defining asynchronous APIs using Apache Kafka. AsyncAPI governed under official guidelines. AsyncAPI is promoted to be used for documentation and code generation. + useCase: At Adidas, AsyncAPI serves as the standard for defining asynchronous APIs using Apache Kafka. Following official guidelines, we promote its use for documentation and code generation.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
📒 Files selected for processing (2)
- components/sponsors/SilverSponsorsList.ts (1 hunks)
- config/adopters.yml (1 hunks)
🧰 Additional context used
🪛 yamllint
config/adopters.yml
[error] 95-95: no new line character at the end of file
(new-line-at-end-of-file)
🔇 Additional comments (2)
components/sponsors/SilverSponsorsList.ts (1)
7-7: LGTM! Improved alt text for better accessibility.The updated alt text provides more descriptive information about the Bump.sh service, which improves accessibility for screen readers.
config/adopters.yml (1)
Line range hint
1-83: Verify the intentional removal of existing adopters.The changes remove 12 company entries including major adopters like Walmart, eBay, and Adobe. Since the PR objective only mentions adding Adidas and Morgan Stanley, please confirm if removing the existing adopters was intentional.
🧰 Tools
🪛 yamllint
[error] 95-95: no new line character at the end of file
(new-line-at-end-of-file)
derberg
changed the title
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Outside diff range and nitpick comments (3)
config/adopters.yml (3)
85-86: Improve clarity of the use case description.The current description contains sentence fragments and redundant mentions. Consider revising for better clarity:
- useCase: AsyncAPI is a standard for defining asynchronous APIs using Apache Kafka. AsyncAPI governed under official guidelines. AsyncAPI is promoted to be used for documentation and code generation. + useCase: We use AsyncAPI as our standard for defining asynchronous APIs with Apache Kafka. The implementation follows official guidelines, and we promote its use for both documentation and code generation.
91-92: Enhance use case description with implementation details.The current description focuses on promotion but lacks technical details. Consider adding information about the WebSocket implementation mentioned in the resource:
- useCase: AsyncAPI is promoted not only inside the company but also as a standard for FinOS Foundation for managing architecture as code. + useCase: We implement and promote AsyncAPI across the company, particularly for WebSocket-based services, while also advocating for it as a standard within the FinOS Foundation for managing architecture as code.
89-89: Consider hosting presentation content on a more stable platform.Several resources link to Google Drive presentations, which may have access control issues or become inaccessible. Consider:
- Hosting the content on a more stable platform (e.g., company website, GitHub)
- Providing alternative formats (e.g., blog posts, documentation)
Also applies to: 95-95
|
/rtm |
5 participants
Also adding alt text on request of one sponsor
Summary by CodeRabbit
New Features
altTextfor the sponsor "Bump.sh" to provide clearer context.Bug Fixes