Skip to content

feat: create banner for online conf #3312

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Oct 27, 2024
Merged

feat: create banner for online conf #3312

Changes from 3 commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
5a40ab8
Update banners.ts
thulieblack Oct 21, 2024
17b8b0d
correct-text
thulieblack Oct 21, 2024
7639112
correct-text
thulieblack Oct 21, 2024
b50bdb7
updated banners conditional render
akshatnema Oct 23, 2024
ff8a6bd
Merge branch 'master' into thulieblack-patch-2
thulieblack Oct 23, 2024
bef2e01
updated banners conditional render
akshatnema Oct 23, 2024
7ad3ff6
fixed AnnouncementHero component
akshatnema Oct 23, 2024
db4009b
fixed AnnouncementHero component
akshatnema Oct 23, 2024
e408168
Merge branch 'master' into thulieblack-patch-2
anshgoyalevil Oct 23, 2024
63e6a9c
Merge branch 'master' into thulieblack-patch-2
akshatnema Oct 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions components/campaigns/banners.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,18 +15,18 @@ function shouldShowBanner(cfpDeadline: string) {
return true;
}

const cfpDeadlineParis = '2024-10-12T06:00:00Z';
const cfpDeadlineParis = '2024-10-30T06:00:00Z';
Copy link
Member

@akshatnema akshatnema Oct 21, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of using this variable, can you please add this inside map? It is very confusing to understand why are we giving cfpDeadlineParis deadline to every banner 😅

Copy link
Member Author

@thulieblack thulieblack Oct 21, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm lost @akshatnema please explain. Oooh I used default cfpparis because it was a quick change after the Paris banner 🫣🫣🫣

const showBannerParis = shouldShowBanner(cfpDeadlineParis);

export const banners = [
{
title: "AsyncAPI Conf on Tour'24",
city: 'Paris',
dateLocation: '3rd - 5th of December, 2024 | France, Paris',
cfaText: 'Apply To Speak',
eventName: 'the end of Call for Speakers',
title: "AsyncAPI Online Conference'24",
city: 'YouTube',
dateLocation: '30th of October, 2024 | YouTube & LinkedIn',
cfaText: 'Join us Live',
eventName: 'the AsyncAPI Online Conference',
cfpDeadline: cfpDeadlineParis,
link: 'https://conference.asyncapi.com/venue/Paris',
link: 'https://www.youtube.com/live/F9wHxd-v2f0?si=kPCqgUzqAKC0FaqJ',
show: showBannerParis
}
];
Loading