Skip to content

chore(blog): using JSON Schema beyond validation #314

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 21 commits into from
Aug 3, 2021
Merged

chore(blog): using JSON Schema beyond validation #314

merged 21 commits into from
Aug 3, 2021

Conversation

@jonaslagoni
Copy link
Member

@jonaslagoni jonaslagoni commented Jul 27, 2021 •
edited
Loading

Description
This blog post brings some light on the struggles in regards to using JSON Schema beyond validation. It gives a quick intro to some basic JSON Schema, as well as some more complex ones and how it affects tooling.

This blog post is supposed to be readable by someone who doesn't know JSON Schema and (hopefully) gives a clear understanding of the struggles in tooling.

Any feedback is appreciated 👍

@netlify
Copy link

netlify bot commented Jul 27, 2021 •
edited
Loading

✔️ Deploy Preview for asyncapi-website ready!
Built without sensitive environment variables

🔨 Explore the source changes: 4239eee

🔍 Inspect the deploy log: https://app.netlify.com/sites/asyncapi-website/deploys/61082fb28fa4bd00086960b9

😎 Browse the preview: https://deploy-preview-314--asyncapi-website.netlify.app

@jonaslagoni jonaslagoni changed the title chore(blog): Using JSON Schema beyond validation chore(blog): using JSON Schema beyond validation Jul 27, 2021
fmvilas
fmvilas requested changes Jul 27, 2021
View reviewed changes
Copy link
Member

@fmvilas fmvilas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great stuff 👏

smoya
smoya reviewed Jul 27, 2021
View reviewed changes
Copy link
Member

@smoya smoya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice post!! 🎉 👏

Added some comments after my review, some suggestions and nitpicks mainly.

smoya
smoya previously approved these changes Jul 28, 2021
View reviewed changes
Copy link
Member

@smoya smoya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀 🌔

Great stuff @jonaslagoni !

@jonaslagoni jonaslagoni requested a review from fmvilas July 28, 2021 08:35
fmvilas
fmvilas previously approved these changes Jul 28, 2021
View reviewed changes
Copy link
Member

@fmvilas fmvilas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@jonaslagoni
Copy link
Member Author

jonaslagoni commented Jul 28, 2021

Thanks for the review and kind words @smoya @fmvilas 🙇

@jonaslagoni
Copy link
Member Author

jonaslagoni commented Jul 28, 2021 •
edited
Loading

Want to do the final review for changes Mr guardian? 😄 @derberg

@derberg
Copy link
Member

derberg commented Jul 28, 2021

@jonaslagoni
Copy link
Member Author

jonaslagoni commented Jul 28, 2021

Was that a no 😆?

derberg
derberg reviewed Jul 28, 2021
View reviewed changes
Copy link
Member

@derberg derberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

like it! some comments

@jonaslagoni jonaslagoni dismissed stale reviews from fmvilas and smoya via 646bc46 July 28, 2021 15:10
@jonaslagoni
Copy link
Member Author

jonaslagoni commented Jul 29, 2021

Just FYI, we need to delay the release of the blog post until the SIG repository is published 🙂

@jonaslagoni
Copy link
Member Author

jonaslagoni commented Jul 30, 2021 •
edited
Loading

We can go ahead and finish this PR now @derberg 🙂

@jonaslagoni jonaslagoni requested a review from derberg July 30, 2021 09:06
@derberg
Copy link
Member

derberg commented Aug 2, 2021

@jonaslagoni when do you want to publish? set a proper date other than Monday/Friday

derberg
derberg reviewed Aug 2, 2021
View reviewed changes
jonaslagoni
jonaslagoni commented Aug 2, 2021
View reviewed changes
@jonaslagoni
Copy link
Member Author

jonaslagoni commented Aug 2, 2021

@jonaslagoni when do you want to publish? set a proper date other than Monday/Friday

Left just release it tomorrow if that's good @derberg 🤔?

@derberg derberg merged commit f11c1ea into asyncapi:master Aug 3, 2021
@jonaslagoni jonaslagoni deleted the feature/json_schema_beyond_validation branch August 16, 2021 10:13
@coderabbitai coderabbitai bot mentioned this pull request Jan 24, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@derberg derberg derberg approved these changes

@fmvilas fmvilas fmvilas left review comments

+1 more reviewer

@smoya smoya smoya left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@jonaslagoni @derberg @fmvilas @smoya