Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] tweetLimit in community/newsroom isn't been reflected #3132

Open
2 tasks done
Saumya40-codes opened this issue Aug 7, 2024 · 7 comments · May be fixed by #3138 or #3220
Open
2 tasks done

[BUG] tweetLimit in community/newsroom isn't been reflected #3132

Saumya40-codes opened this issue Aug 7, 2024 · 7 comments · May be fixed by #3138 or #3220
Labels
bug good first issue Good for newcomers

Comments

@Saumya40-codes
Copy link
Contributor

Saumya40-codes commented Aug 7, 2024

Describe the bug.

Currently in community/newsroom page here, we are using TwitterTimelineEmbed from react-twitter-embed package to show the twitter timeline, though we have mentioned tweetLimit:2 in our code, it isn't being reflect upon.

The code block

<div className='w-full px-2 md:w-1/2 md:pl-4 md:pr-0'>
    <div className='mx-auto mt-8 w-full rounded-xl shadow-md md:mt-0' data-testid='Newsroom-Twitter'>
      <TwitterTimelineEmbed sourceType='profile' screenName='AsyncAPISpec' options={{ tweetLimit: '2' }} />
    </div>
  </div>

Due to this many tweets are being loaded all together.

Expected behavior

Only limited amount of latest tweets should be shown, but when I looked within the react-twitter-embed package, this surely doesn't seem to be possible (as there are many issues already related to that like this ), but what we can do is to make the component scrollable by setting a specific height in the options attribute of the component, as it was mentioned in the package's source code:

image

Expected behaviour at the end should look something like this:

AsyncAPI.Newsroom._.AsyncAPI.Initiative.for.event-driven.APIs.-.Google.Chrome.2024-08-07.20-54-55.mp4

I'll make sure this aligns well with the current existing UI above just shows a probable fix to this.

Screenshots

Current Behaviour:

AsyncAPI.Newsroom._.AsyncAPI.Initiative.for.event-driven.APIs.-.Google.Chrome.2024-08-07.20-50-46.mp4

How to Reproduce

visit this page and head over to Latest News section

🥦 Browser

Google Chrome

👀 Have you checked for similar open issues?

  • I checked and didn't find similar issue

🏢 Have you read the Contributing Guidelines?

Are you willing to work on this issue ?

Yes I am willing to submit a PR!

@sambhavgupta0705
Copy link
Member

image

I am seeing this
@Saumya40-codes would you like to work on this issue

@sambhavgupta0705
Copy link
Member

/gfi

@asyncapi-bot
Copy link
Contributor

Hey @sambhavgupta0705, your message doesn't follow the requirements, you can try /help.

@sambhavgupta0705 sambhavgupta0705 added the good first issue Good for newcomers label Aug 9, 2024
@Saumya40-codes
Copy link
Contributor Author

Saumya40-codes commented Aug 9, 2024

image

I am seeing this @Saumya40-codes would you like to work on this issue

Yes i'll like to fix this!

It looking like that most probably because your current device isnt being logged in to Twitter/X, I'll try to look for some fix here so that it can be looked publically

@Saumya40-codes
Copy link
Contributor Author

Additionally should we also consider adding scrollbar to contain the amount of tweets being show? (as I mentioned in the main issue)

@HalfToothed
Copy link

i am using Firefox Developer Edition and i am not able to see the twitter section, it is working as expected in google chrome and microsoft edge

Screenshot 2024-08-10 114757

@vin-dKR
Copy link

vin-dKR commented Aug 20, 2024

I had the same experience with the X timeline. After some research, I discovered that Twitter timelines can be generated using https://publish.twitter.com/ . However, it seems that this feature is not enabled for every account. Specifically, accounts with a blue tick have their timelines displayed correctly, while most accounts without a blue tick are not showing their tweets, there are some non-blue tick accounts that do display their timelines correctly. This discrepancy might be the root cause of the issue we're experiencing.
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug good first issue Good for newcomers
Projects
None yet
5 participants