Skip to content

Conversation

@derberg
Copy link
Member

@derberg derberg commented Sep 28, 2021

derberg and others added 8 commits September 16, 2021 12:02
* added servers field to channel object

* no space before function object parentheses

* split test for servers()

* documenting index parameter to server()

Co-authored-by: Maciej Urbańczyk <urbanczyk.maciej.95@gmail.com>

* added custom validator: server list on channel object must include only known servers

* fixed docs

* better error title for server validation errors

Co-authored-by: Maciej Urbańczyk <urbanczyk.maciej.95@gmail.com>

* better error title for server validation errors

Co-authored-by: Maciej Urbańczyk <urbanczyk.maciej.95@gmail.com>

Co-authored-by: Maciej Urbańczyk <urbanczyk.maciej.95@gmail.com>
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link
Member

@magicmatatjahu magicmatatjahu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀

@derberg derberg merged commit 41e135b into master Sep 28, 2021
@derberg derberg deleted the 2021-09-release branch September 28, 2021 13:13
@axolo-co
Copy link

axolo-co bot commented Sep 28, 2021

Link to Slack conversation.

Axolo's notification on Slack Channel creation

28/09/2021
_01:07 PM: _ undefined has joined the channel

01:07 PM: derberg derberg has joined the channel

_01:07 PM: _ set the channel topic: Branch: 2021-09-release | Link to PR : #376

01:11 PM: urbanczyk.maciej.95 urbanczyk.maciej.95 has joined the channel

Start of the conversation

28/09/2021
_01:07 PM: _ derberg created a pull request

_01:11 PM: _ derberg asked magicmatatjahu to review feat: release 2.2.0 spec version pull request on parser-js

_01:12 PM: _ 🥳 magicmatatjahu approved this pull request !

@asyncapi-bot
Copy link
Contributor

🎉 This PR is included in version 1.10.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants