Skip to content

feat: added traits() and hasTraits() functions #357

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
magicmatatjahu merged 4 commits into from
Sep 8, 2021
Merged

feat: added traits() and hasTraits() functions #357

magicmatatjahu merged 4 commits into from
Sep 8, 2021

Conversation

@KhudaDad414
Copy link
Member

@KhudaDad414 KhudaDad414 commented Sep 7, 2021

Description

  • this PR will add the above functions to the Message and Operation classes.

Related issue(s)
Resolves #226

@KhudaDad414 KhudaDad414 marked this pull request as draft September 7, 2021 17:05
@KhudaDad414 KhudaDad414 marked this pull request as ready for review September 7, 2021 17:31
@KhudaDad414
Copy link
Member Author

KhudaDad414 commented Sep 7, 2021

This PR is ready for review.

magicmatatjahu
magicmatatjahu reviewed Sep 7, 2021
View reviewed changes
Copy link
Member

@magicmatatjahu magicmatatjahu left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@KhudaDad414 Thanks for contribution. If PR is ready, you can always request for review:

image

About PR, overall good, but I don't see logic for handling situation when someone pass applyTraits: true as option to the parser :) I wrote how it can be handled in this comment: #226 (comment)

magicmatatjahu
magicmatatjahu requested changes Sep 8, 2021
View reviewed changes
@sonarqubecloud
Copy link

sonarqubecloud bot commented Sep 8, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@KhudaDad414
Copy link
Member Author

KhudaDad414 commented Sep 8, 2021

@KhudaDad414 Thanks for contribution. If PR is ready, you can always request for review:

@magicmatatjahu I don't have the option to request reviews. I can only re-request if someone has already reviewed the PR. 🤔
Capture

@magicmatatjahu
Copy link
Member

magicmatatjahu commented Sep 8, 2021

@KhudaDad414 It is also good, because then as previously reviewer I see your request again :)

magicmatatjahu
magicmatatjahu approved these changes Sep 8, 2021
View reviewed changes
Copy link
Member

@magicmatatjahu magicmatatjahu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for contribution!

@magicmatatjahu magicmatatjahu merged commit 36f9d62 into asyncapi:master Sep 8, 2021
@magicmatatjahu
Copy link
Member

magicmatatjahu commented Sep 8, 2021

@all-contributors please add @KhudaDad414 for code, test

@allcontributors allcontributors bot mentioned this pull request Sep 8, 2021
Merged
@allcontributors
Copy link
Contributor

allcontributors bot commented Sep 8, 2021

@magicmatatjahu

I've put up a pull request to add @KhudaDad414! 🎉

@asyncapi-bot
Copy link
Contributor

asyncapi-bot commented Sep 8, 2021

🎉 This PR is included in version 1.9.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@KhudaDad414 KhudaDad414 deleted the feat_trait_traits branch April 29, 2022 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@magicmatatjahu magicmatatjahu magicmatatjahu approved these changes

Assignees

No one assigned

Labels

released

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

No functions to access message and operation traits

3 participants

@KhudaDad414 @magicmatatjahu @asyncapi-bot