Skip to content

Conversation

@KhudaDad414
Copy link
Member

Description
makes parser options optional for Typescript projects.
Related issue(s)
Resolves #354

@jonaslagoni
Copy link
Member

@KhudaDad414 thanks for the fast fix!

Can you rename the title of the pr to include fix: ...? 🙂

@KhudaDad414 KhudaDad414 changed the title added optional sign to jsdoc fix: added optional sign to ParserOptions's jsdoc Sep 6, 2021
@sonarqubecloud
Copy link

sonarqubecloud bot commented Sep 6, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link
Member

@jonaslagoni jonaslagoni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@jonaslagoni jonaslagoni merged commit 2d9e328 into asyncapi:master Sep 6, 2021
@KhudaDad414 KhudaDad414 deleted the fix_parser_options branch September 6, 2021 14:27
@asyncapi-bot
Copy link
Contributor

🎉 This PR is included in version 1.8.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Setting applyTraits on Typescript projects

3 participants