Skip to content

Conversation

@iamdevelopergirl
Copy link
Contributor

@iamdevelopergirl iamdevelopergirl commented Aug 25, 2021

Description

  • Exposing the options argument in the parser function as a separate type, so that it can be reused.

Related issue(s)
Fixes #345

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome to AsyncAPI. Thanks a lot for creating your first pull request. Please check out our contributors guide and the instructions about a basic recommended setup useful for opening a pull request.

Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.

@iamdevelopergirl iamdevelopergirl changed the title expose parser options as a seperate type fix: expose parser options as a seperate type Aug 26, 2021
Copy link
Member

@magicmatatjahu magicmatatjahu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@iamdevelopergirl Hi! Thanks for contribution! Please also change link to the type in the functions:

function parseFromUrl(url, fetchOptions, options) {

async function customChannelsOperations(parsedJSON, asyncapiYAMLorJSON, initialFormat, options) {

async function customComponentsMsgOperations(parsedJSON, asyncapiYAMLorJSON, initialFormat, options) {

I mean last options argument should point to the ParserOptions type.

Please also change the prefix of PR to the feat: :)

@iamdevelopergirl iamdevelopergirl changed the title fix: expose parser options as a seperate type feat: expose parser options as a seperate type Aug 27, 2021
@iamdevelopergirl
Copy link
Contributor Author

Addressed the review comments.

@magicmatatjahu
Copy link
Member

@iamdevelopergirl Hello! Sorry for late review, could you add my suggestions? :)

Copy link
Contributor Author

@iamdevelopergirl iamdevelopergirl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added the suggestions to change the type of options

@iamdevelopergirl
Copy link
Contributor Author

Thanks for making the changes. Guess I overlooked the type of options param. :)

@magicmatatjahu
Copy link
Member

@iamdevelopergirl Sorry, I don't see them. Did you push them or do you have only in the local repo? 😅

Co-authored-by: Maciej Urbańczyk <urbanczyk.maciej.95@gmail.com>
@iamdevelopergirl
Copy link
Contributor Author

@magicmatatjahu Right, you got me :)
Added it now.

@magicmatatjahu
Copy link
Member

@iamdevelopergirl No worries :) If I could, last thing. Could you rebase your repo with base (master) branch? I don't have permission to do that by myself (and it blocks me to merge), so you must do it in your side.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Sep 2, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@iamdevelopergirl
Copy link
Contributor Author

Yep. Done 👍

@magicmatatjahu magicmatatjahu merged commit 401fcb3 into asyncapi:master Sep 2, 2021
@magicmatatjahu
Copy link
Member

@iamdevelopergirl Thanks for contribution and patience 😅

@magicmatatjahu
Copy link
Member

@all-contributors please add @iamdevelopergirl for code

@allcontributors
Copy link
Contributor

@magicmatatjahu

I've put up a pull request to add @iamdevelopergirl! 🎉

@asyncapi-bot
Copy link
Contributor

🎉 This PR is included in version 1.8.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@iamdevelopergirl
Copy link
Contributor Author

Cool. Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Expose parser options in separate type

3 participants