-
-
Notifications
You must be signed in to change notification settings - Fork 117
feat: expose parser options as a seperate type #346
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: expose parser options as a seperate type #346
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Welcome to AsyncAPI. Thanks a lot for creating your first pull request. Please check out our contributors guide and the instructions about a basic recommended setup useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.
magicmatatjahu
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@iamdevelopergirl Hi! Thanks for contribution! Please also change link to the type in the functions:
Line 129 in 07b739b
| function parseFromUrl(url, fetchOptions, options) { |
Line 253 in 07b739b
| async function customChannelsOperations(parsedJSON, asyncapiYAMLorJSON, initialFormat, options) { |
Line 284 in 07b739b
| async function customComponentsMsgOperations(parsedJSON, asyncapiYAMLorJSON, initialFormat, options) { |
I mean last options argument should point to the ParserOptions type.
Please also change the prefix of PR to the feat: :)
|
Addressed the review comments. |
|
@iamdevelopergirl Hello! Sorry for late review, could you add my suggestions? :) |
iamdevelopergirl
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added the suggestions to change the type of options
|
Thanks for making the changes. Guess I overlooked the type of options param. :) |
|
@iamdevelopergirl Sorry, I don't see them. Did you push them or do you have only in the local repo? 😅 |
Co-authored-by: Maciej Urbańczyk <urbanczyk.maciej.95@gmail.com>
|
@magicmatatjahu Right, you got me :) |
|
@iamdevelopergirl No worries :) If I could, last thing. Could you rebase your repo with base (master) branch? I don't have permission to do that by myself (and it blocks me to merge), so you must do it in your side. |
|
Kudos, SonarCloud Quality Gate passed!
|
|
Yep. Done 👍 |
|
@iamdevelopergirl Thanks for contribution and patience 😅 |
|
@all-contributors please add @iamdevelopergirl for code |
|
I've put up a pull request to add @iamdevelopergirl! 🎉 |
|
🎉 This PR is included in version 1.8.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
Cool. Thanks |








Description
Related issue(s)
Fixes #345