Skip to content

revert #7 #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

revert #7 #11

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 4 additions & 6 deletions src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -147,9 +147,7 @@ pub fn test(_attr: TokenStream, item: TokenStream) -> TokenStream {
///
/// #[async_attributes::bench]
/// async fn bench_1(b: &mut test::Bencher) {
/// b.iter(|| {
/// println!("hello world");
/// })
/// println!("hello world");
Copy link

@ghost ghost Nov 2, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aren't we missing b.iter(...) here?

Copy link
Collaborator Author

@yoshuawuyts yoshuawuyts Nov 3, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is now part of the macro again, unfortunately.

/// }
/// ```
#[proc_macro_attribute]
Expand Down Expand Up @@ -178,9 +176,9 @@ pub fn bench(_attr: TokenStream, item: TokenStream) -> TokenStream {
#[bench]
#(#attrs)*
fn #name(b: &mut test::Bencher) #ret {
task::block_on(task::spawn(async {
#body
}))
b.iter(|| {
let _ = async_std::task::block_on(async { #body });
});
}
};

Expand Down