-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix ambiguous import on standalone helper components (fixes #72) #73
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ts. Improved the TS type definitions.
Codecov Report
@@ Coverage Diff @@
## master #73 +/- ##
=======================================
Coverage 99.28% 99.28%
=======================================
Files 9 9
Lines 703 703
Branches 158 158
=======================================
Hits 698 698
Misses 5 5
Continue to review full report at Codecov.
|
This branch was just published as |
Released in v8.0.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This resolves an issue with ambiguous imports, where helpers such as
Fulfilled
clash withReact.Fulfilled
. The solution is to rename all helper components toIfX
, e.g.IfFulfilled
.This also fixes #72 the TypeScript definitions for helper components.
Breaking changes
All helper components are renamed without backwards compatibility. To upgrade:
<Initial
with<IfInitial
<Pending
with<IfPending
<Fulfilled
with<IfFulfilled
<Rejected
with<IfRejected
<Settled
with<IfSettled
Checklist
Make sure you check all the boxes. You can omit items that are not applicable.