Well, there goes my entire weekend... ^^ (This is the correct one) #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add images to remanescent faction-related notifications
File extension correction on faction-relative notifications.
When possible, clicking on some card which is being displayed in details will play it.
Deleting in order to upload a new file tree
Deleting in order to upload a new file tree
Deleting in order to upload a new file tree
Deleting in order to upload a new file tree
Adds: 1 - a page for rules (by @romain-durban, author of version 3.0), 2 - an A.I. vs A.I. option (by @romain-durban, author of version 3.0), 3 - a statistics table, 4 - a "give up" button
Adds: 1 - a page for rules (by @romain-durban, author of version 3.0), 2 - an A.I. vs A.I. option (by @romain-durban, author of version 3.0), 3 - a whole new set of cards and mechanics (by @romain-durban, author of version 3.0), 4 - a statistics table, 5 - a "give up" button, 6 - new visuals for carousel. Corrects: 1 - aesthetic values, 2 - unused code, 3 - bug in leader selection, 4 - bug when drawing a match, 5 - typo errors, 6 - bug when redrawing cards at the start of each match.
WolfSpiderman
approved these changes
Dec 12, 2023
Cards in deck selector are now shown in alphabetical order
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
THIS IS AN UPDATED VERSION OF MY PULL REQUEST
I saw this repo at saturday morning and I felt the urge of dive myself in async JavaScript.
Now it's Sunday 11pm (now Monday 6pm) in Brazil and I do not regret anything. Maybe I should eat something lol
Anyway, your application is superb, but I dare propose a few ameliorations.
Improvements
Changes
Operations included with the keyboard:
"E" starts the game
"X" uses or modifies the leader card
"Q" closes the card explanation windows
"Space" passes the current round
"Enter" plays the cards
Arrows select cards on the carousel