feat: SDSS-V (astra) model spectra default loader #1203
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1203 +/- ##
==========================================
+ Coverage 86.90% 87.06% +0.15%
==========================================
Files 63 63
Lines 4576 4645 +69
==========================================
+ Hits 3977 4044 +67
- Misses 599 601 +2 ☔ View full report in Codecov by Sentry. |
|
i forgot to mark this as ready 2 months ago, should be good now |
- adds astraMODELStar and astraMODELVisit spectrum loaders
- no longer checks for "date_obs"; calculate that yourself - also adds "sdss_id" to metadata now
…ases - added new test cases for BOSS-only mwmVisit and mwmStar files - added new checks to SpectrumList mwmVisit/mwmStar test to check verified filetype is correct - forced override on default SpectrumList loaders -- now SpectrumList is no longer ambiguous and doesn't require a format specification - relevant areas in tests are updated accordingly - added print warnings to when HDU is not specified on Spectrum1D loaders for files with multiple spectra. - ensured tests now remove tempfiles with os.remove - arguably, this could work better with tmpfile, but i don't know how tests are deployed on the server-side
- three points outlining changes listed in PR as per astropy#1185
- all loaders now only load for a single datatype, avoiding prior knowledge of SDSS datatypes - updated to only load as SpectrumList - updated to load all visits in mwmVisit files as individual Spectrum1D objects in the SpectrumList - relevant tests removed - relevant import __all__ adjusted
Co-authored-by: Brian Cherinka <[email protected]>
- describes changes shown previously
revert back to 4bee136
- readded print -> warnings conversion - can specify the visit to load on mwmVisit load. - added relevant tests for the new mwmVisit case
NOTE: this requires the mwmvisit boss fix pr as well
- clear on what it does
rosteen
force-pushed
the
add-astra-loader
branch
from
2743fff to
81626fa
Compare
|
@rileythai I rebased this and am seeing test failures - would you double check against your local branch and make sure I didn't botch something in the rebase? This was originally from before the 2.0 release, so there certainly could be changes needed to get it up to date beyond what I did to resolve the conflicts. Apologies for missing this when you initially marked it ready for review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses #1183 , and adds a default loader for the model spectra from SDSS-V's astra with relevant tests.