MAINT: removing usage of deprecated astropy.utils.misc.indent #539
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Btw, only one of the 3 affected files caused a test failure which suggests some missing coverage (but fixing that points beyond the scope of this PR) |
andamian
approved these changes
Apr 17, 2024
pyvo/io/vosi/tapregext.py
Outdated
| @@ -37,7 +37,7 @@ def describe(self): | |||
| Prints out a human readable description | |||
| """ | |||
| print("Datamodel {}".format(self.content)) | |||
| print(indent(self.ivo_id)) | |||
| print(indent(self.ivo_id, 4 * " ")) | |||
There was a problem hiding this comment.
Could define 4 spaces as an INDENT const a refer to it through the file(s). Just a suggestion.
bsipocz
force-pushed
the
MAINT_astropy6.1_indent_dep
branch
from
8136b91 to
2d3f380
Compare
bsipocz
added a commit
that referenced
this pull request
May 22, 2024
MAINT: removing usage of deprecated astropy.utils.misc.indent
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix some CI failures in the devtest job.