Skip to content

Conversation

cosmoJFH
Copy link
Contributor

Dear astroquery team,

the delete_user_table method, defined in the TapPlus module, allows to delete programmatically a user table. The method is described in Sect.2.4 in the Astroquery.Gaia documentation with the following example:

Gaia.login_gui()
job = Gaia.delete_user_table(table_name="table_test_from_file")

In the example, it is not necessary to specify the schema name of the user table to delete it (although it is also possible to add it without breaking the deletion functionality).

Due to changes carried out in the TAP library (version 10.x) at ESAC, now it is necessary to specify the schema instead of just the table name. In other words, the input must be "user_<user_name>.<table_name>" instead of "<table_name>" in order to make the method work.

On top of that, this new behaviour differs from what the other user space management methods do, since all of them accept the table name as inputs.

Gaia.login_gui()
Gaia.upload_table(upload_resource=file, table_name="table_test_from_file", format="votable") # Upload table from local file
Gaia.upload_table(upload_resource=res,  table_name='table_test_from_astropy')                # Upload table from astropy table object
Gaia.upload_table_from_job(job=job,     table_name='table_test_from_job')                    # Upload table from async job stored in the Archive user space

Therefore, we would like to modify the method delete_user_table to ensure that it can also accept just the table name (which means recovering the lost functionality and making it sure that there is no breaking change in OPS).

Note that this issue was detected both in Euclid and Gaia projects.

cc @esdc-esac-esa-int
jira: EUCLIDSWRQ-258 GAIASWRQ-125

Copy link

codecov bot commented Oct 11, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 70.71%. Comparing base (aaa6e53) to head (2de49d6).
⚠️ Report is 9 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3439      +/-   ##
==========================================
+ Coverage   70.54%   70.71%   +0.16%     
==========================================
  Files         232      232              
  Lines       20022    20029       +7     
==========================================
+ Hits        14125    14163      +38     
+ Misses       5897     5866      -31     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@cosmoJFH cosmoJFH force-pushed the ESA_euclid_EUCLIDSWRQ-258_GAIASWRQ-125_include_schema_in_delete_user_table_method branch from bec7906 to 36c29d7 Compare October 11, 2025 09:27
@cosmoJFH cosmoJFH changed the title TAP: include schema in delete user table method TAP: include schema name in delete_user_table method Oct 11, 2025
@cosmoJFH cosmoJFH force-pushed the ESA_euclid_EUCLIDSWRQ-258_GAIASWRQ-125_include_schema_in_delete_user_table_method branch from 9ca5e68 to 5ea5c59 Compare October 11, 2025 09:35
@cosmoJFH cosmoJFH force-pushed the ESA_euclid_EUCLIDSWRQ-258_GAIASWRQ-125_include_schema_in_delete_user_table_method branch 2 times, most recently from c43304b to 6356000 Compare October 11, 2025 12:14
@jespinosaar
Copy link
Contributor

Dear @cosmoJFH ,
I think this is not affecting other ESA modules so, as long as this works for Euclid and Gaia, this should be fine.
But please, bear in mind that the tests are not passing, so you will need to modify them.

@cosmoJFH cosmoJFH force-pushed the ESA_euclid_EUCLIDSWRQ-258_GAIASWRQ-125_include_schema_in_delete_user_table_method branch from 1d59ab3 to b2a2a27 Compare October 14, 2025 07:11
@cosmoJFH cosmoJFH force-pushed the ESA_euclid_EUCLIDSWRQ-258_GAIASWRQ-125_include_schema_in_delete_user_table_method branch from 0521466 to 2de49d6 Compare October 14, 2025 07:13
@cosmoJFH
Copy link
Contributor Author

cosmoJFH commented Oct 14, 2025

Hi @jespinosaar, thanks for reviewing possible side effects of this change in other esa modules. We fixed a minor error introduced in the last commit. Now the tests are ok.

@jespinosaar
Copy link
Contributor

Great, thanks @cosmoJFH ! Please let us know if you have further comments, @bsipocz . We are preparing for an internal release at the end of this month, so it would be great if we could have this reviewed and merged by next week.

Copy link
Member

@bsipocz bsipocz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tests are looking good regarding this for every ESA modules, and I only have one minor comment that I'll just push directly to the branch before merging.

Thanks!

@bsipocz bsipocz merged commit c0a1a84 into astropy:main Oct 17, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants