-
-
Notifications
You must be signed in to change notification settings - Fork 423
TAP: include schema name in delete_user_table method #3439
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TAP: include schema name in delete_user_table method #3439
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3439 +/- ##
==========================================
+ Coverage 70.54% 70.71% +0.16%
==========================================
Files 232 232
Lines 20022 20029 +7
==========================================
+ Hits 14125 14163 +38
+ Misses 5897 5866 -31 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
bec7906
to
36c29d7
Compare
9ca5e68
to
5ea5c59
Compare
c43304b
to
6356000
Compare
Dear @cosmoJFH , |
1d59ab3
to
b2a2a27
Compare
0521466
to
2de49d6
Compare
Hi @jespinosaar, thanks for reviewing possible side effects of this change in other esa modules. We fixed a minor error introduced in the last commit. Now the tests are ok. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tests are looking good regarding this for every ESA modules, and I only have one minor comment that I'll just push directly to the branch before merging.
Thanks!
Dear astroquery team,
the delete_user_table method, defined in the TapPlus module, allows to delete programmatically a user table. The method is described in Sect.2.4 in the Astroquery.Gaia documentation with the following example:
In the example, it is not necessary to specify the schema name of the user table to delete it (although it is also possible to add it without breaking the deletion functionality).
Due to changes carried out in the TAP library (version 10.x) at ESAC, now it is necessary to specify the schema instead of just the table name. In other words, the input must be "user_<user_name>.<table_name>" instead of "<table_name>" in order to make the method work.
On top of that, this new behaviour differs from what the other user space management methods do, since all of them accept the table name as inputs.
Therefore, we would like to modify the method delete_user_table to ensure that it can also accept just the table name (which means recovering the lost functionality and making it sure that there is no breaking change in OPS).
Note that this issue was detected both in Euclid and Gaia projects.
cc @esdc-esac-esa-int
jira: EUCLIDSWRQ-258 GAIASWRQ-125