Skip to content

Conversation

hhsieh00
Copy link

@hhsieh00 hhsieh00 commented Feb 4, 2025

This is a new module for querying the Lowell Observatory astorbDB database (see issue #3129), specifically using REST APIs used to run their AstInfo tool (https://asteroid.lowell.edu/astinfo/). The AstInfo class in this module specifically retrieves designation, orbital element, orbit, albedo, color, taxonomy, lightcurve, dynamical family, and escape route data for asteroids catalogued in the Lowell astorbDB database.

@bsipocz bsipocz added this to the v0.4.10 milestone Feb 4, 2025
@bsipocz bsipocz marked this pull request as draft February 4, 2025 20:25
@mkelley mkelley self-requested a review February 5, 2025 20:56
Copy link
Contributor

@mkelley mkelley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and very useful in general. Some initial comments and questions to address while you continue testing.

@bsipocz
Copy link
Member

bsipocz commented Feb 15, 2025

Thanks @mkelley for the review. I haven't looked into it in any meaningful way yet, but I notice that there are a lot of comments on async stuff. We should remove/rework the template module as a lot has changed. E.g. there is a preference of supporting actual async/sync API and not just with the early template hackary. So I would suggest to so that, too, if the service support async, then opt into that with a keyword argument, but don't duplicate the methods with the decorator.

#2598

or one PR that did the keyword approach: #3201 or the ESA modules also have a async_job keyword to switch between sync and async query modes.

@bsipocz bsipocz removed this from the v0.4.10 milestone Mar 18, 2025
First complete draft of the astorbdb class including tests and documentation
removed get_raw_response lines, changed names of dynamical_family and escape_routes methods, changed OrderedDict output to regular dictionaries. Also re-ordered methods in alphabetical order.  Other minor edits.
fixed dynamical_family and escape_route function names in documentation; also added astorbdb.rst to various toc files
@mkelley
Copy link
Contributor

mkelley commented Oct 21, 2025

I'm not sure why the checks didn't run. @hhsieh00 You might want to try to git rebase with an updated astroquery/main and then push the updates.

query code only for now; tests not written yet
Fixing some codestyle issues in core.py
fixing more codestyle issues in core.py
First complete draft of the astorbdb class including tests and documentation
@codecov
Copy link

codecov bot commented Oct 21, 2025

Codecov Report

❌ Patch coverage is 98.43137% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 71.07%. Comparing base (b4ccef0) to head (956af7e).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
astroquery/astorbdb/core.py 98.37% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3203      +/-   ##
==========================================
+ Coverage   70.72%   71.07%   +0.34%     
==========================================
  Files         232      235       +3     
  Lines       20041    20296     +255     
==========================================
+ Hits        14174    14425     +251     
- Misses       5867     5871       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

removed get_raw_response lines, changed names of dynamical_family and escape_routes methods, changed OrderedDict output to regular dictionaries. Also re-ordered methods in alphabetical order.  Other minor edits.
fixed dynamical_family and escape_route function names in documentation; also added astorbdb.rst to various toc files
query code only for now; tests not written yet
Fixing some codestyle issues in core.py
fixing more codestyle issues in core.py
First complete draft of the astorbdb class including tests and documentation
removed get_raw_response lines, changed names of dynamical_family and escape_routes methods, changed OrderedDict output to regular dictionaries. Also re-ordered methods in alphabetical order.  Other minor edits.
query code only for now; tests not written yet
Fixing some codestyle issues in core.py
fixing more codestyle issues in core.py
First complete draft of the astorbdb class including tests and documentation
removed get_raw_response lines, changed names of dynamical_family and escape_routes methods, changed OrderedDict output to regular dictionaries. Also re-ordered methods in alphabetical order.  Other minor edits.
@hhsieh00 hhsieh00 marked this pull request as ready for review October 22, 2025 02:34
@hhsieh00 hhsieh00 requested a review from mkelley October 22, 2025 02:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants