-
-
Notifications
You must be signed in to change notification settings - Fork 424
Fix changing simbad config items at runtime
#2292
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2292 +/- ##
==========================================
+ Coverage 62.99% 63.01% +0.01%
==========================================
Files 133 133
Lines 17291 17300 +9
==========================================
+ Hits 10892 10901 +9
Misses 6399 6399 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like this solution. @bsipocz I'm holding off on pressing merge so you can have a look, but I think this could serve as the template for other modules moving forward.
I would also like to see these parameters also be specifiable at instance creation time, but that can be a conversation on a different thread.
ce2913f to
7877033
Compare
|
I had to rebase to solve a conflict in the change log. |
7877033 to
9b6e00a
Compare
|
I had to rebase again to resolve another merge conflict in the change log. I also decided to add a |
|
I would like to get this change done in the same release for a bunch of the modules (at least the ones that are most often used), and maybe also add the warning #638 suggest (there is one already in mast.missions), so would push this to the next release. |
9b6e00a to
29dccd8
Compare
|
I have rebased the commits to update the change log entry. |
|
For some reason none of the tests ran at all. Should I rebase again to start the tests? |
29dccd8 to
c501f4f
Compare
c501f4f to
924217b
Compare
924217b to
035188a
Compare
|
I've updated the pull request so that the documentation about the Simbad subpackage is kept up to date regarding the configuration, and I had to rebase to resolve a merge conflict in the change log. |
Currently changing Simbad config values at runtime has no effect. The added test reveals the problem.
Previously changing `simbad` config items at runtime had no effect. Now the config items are read when they are needed, unless the user has specified the corresponding class or instance variable, in which case the latter takes precedence.
035188a to
0f6a310
Compare
|
I had to rebase to fix a merge conflict in the change log, again. |
Previously changing
simbadconfig items at runtime had no effect. Now the config items are read when they are needed, unless the user has specified the corresponding class or instance variable, in which case the latter takes precedence.Relevant for #2291