Run ExecutionMode.AIRFLOW_ASYNC dag with deferrable False#12
Merged
Conversation
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
pankajastro
commented
Apr 28, 2026
pankajastro
requested review from
Copilot,
pankajkoti and
tatiana
and removed request for
a team
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds a new Cosmos benchmark path for running the altered jaffle shop BigQuery DAG in AIRFLOW_ASYNC mode while forcing the async operator to behave non-deferrably, so it can be compared against the existing async benchmark setup.
Changes:
- Adds
dags/cosmos_sync_dag.py, a new BigQuery Cosmos DAG that monkey-patches the async BigQuery operator to setdeferrable=False. - Adds
benchmark/experiment/airflow-test-cosmos-sync.yaml, a Kubernetes Job manifest to runairflow dags test cosmos_bq_sync. - Reuses the altered jaffle shop benchmark project and existing GCP connection/profile wiring for the new benchmark path.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
dags/cosmos_sync_dag.py |
Adds the new benchmark DAG and the operator monkey-patch used to disable deferral. |
benchmark/experiment/airflow-test-cosmos-sync.yaml |
Adds the benchmark Job manifest that executes the new DAG in Kubernetes. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
pankajastro
commented
May 5, 2026
pankajastro
commented
May 5, 2026
tatiana
changed the title
ExecutionMode.AIRFLOW_ASYNC dag with deferrable False
Avoids the process-wide monkey-patch on DbtRunAirflowAsyncBigqueryOperator.__init__ that would leak into cosmos_async_dag during DagBag import and silently change the async baseline being benchmarked. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
pankajkoti
approved these changes
May 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depend on
deferrablekwarg inDbtRunAirflowAsyncBigqueryOperatorastronomer-cosmos#2616closes: https://github.com/astronomer/oss-integrations-private/issues/176