fix inplace mutation#842
Closed
dwreeves wants to merge 1 commit into
Closed
Conversation
✅ Deploy Preview for sunny-pastelito-5ecb04 canceled.
|
Collaborator
|
Thanks @dwreeves! This fixes the same issue that #835 tries to fix from user reports in Slack. The inplace updates for astronomer-cosmos/cosmos/converter.py Lines 246 to 253 in 72690d3 |
Collaborator
Author
|
Ah I should have looked at existing PRs. I can close this then. |
This was referenced Jun 26, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
operator_args.pop()causes an in-place mutation, which long story short caused an issue for me today. I think it is a lot safer to rely on acopy()if theDbtToAirflowConverteris going to mutate the user inputs.