Skip to content

Add performance integration tests#827

Merged
jlaneve merged 6 commits into
mainfrom
performance-int-tests
Feb 15, 2024
Merged

Add performance integration tests#827
jlaneve merged 6 commits into
mainfrom
performance-int-tests

Conversation

@jlaneve
Copy link
Copy Markdown
Contributor

@jlaneve jlaneve commented Jan 31, 2024

Description

This PR adds a step to our CI to measure how quickly Cosmos can run models. This is part of a larger initiative to make the project more performant now that it's reached a certain level of maturity.

How it works:

While this isn't perfect, it's a step in the right direction - we now have some general visibility! Note that these numbers may not be indicative of a production Airflow environment running something like the Kubernetes Executor, because this runs a local executor on GH Actions runners. Still, it's meant as a benchmark to demonstrate whether we're moving in the right direction or not.

As part of this, I've also refactored our tests to call a script from the pyproject file instead of embedding the scripts directly in the file. This should make it easier to maintain and track changes.

Related Issue(s)

#800

Breaking Change?

Checklist

  • I have made corresponding changes to the documentation (if required)
  • I have added tests that prove my fix is effective or that my feature works

@netlify
Copy link
Copy Markdown

netlify Bot commented Jan 31, 2024

Deploy Preview for sunny-pastelito-5ecb04 canceled.

Name Link
🔨 Latest commit 18fc743
🔍 Latest deploy log https://app.netlify.com/sites/sunny-pastelito-5ecb04/deploys/65ce1a4955ded200082ba9a5

@codecov
Copy link
Copy Markdown

codecov Bot commented Jan 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (dfdb3f6) 94.40% compared to head (aec1d7e) 94.40%.
Report is 3 commits behind head on main.

❗ Current head aec1d7e differs from pull request most recent head 18fc743. Consider uploading reports for the commit 18fc743 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #827   +/-   ##
=======================================
  Coverage   94.40%   94.40%           
=======================================
  Files          56       56           
  Lines        2520     2520           
=======================================
  Hits         2379     2379           
  Misses        141      141           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Comment thread .github/workflows/test.yml Outdated
@jlaneve jlaneve marked this pull request as ready for review February 14, 2024 00:25
@jlaneve jlaneve requested a review from a team as a code owner February 14, 2024 00:25
@dosubot dosubot Bot added size:L This PR changes 100-499 lines, ignoring generated files. area:performance Related to performance, like memory usage, CPU usage, speed, etc dbt:run Primarily related to dbt run command or functionality execution:local Related to Local execution environment parsing:custom Related to custom parsing, like custom DAG parsing, custom DBT parsing, etc labels Feb 14, 2024
Copy link
Copy Markdown
Collaborator

@jbandoro jbandoro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 this is great! Excited to test out the performance dag in #836 see how much a difference it makes.

Comment thread pyproject.toml
Comment thread tests/test_example_dags.py Outdated
@dosubot dosubot Bot added the lgtm This PR has been approved by a maintainer label Feb 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:performance Related to performance, like memory usage, CPU usage, speed, etc dbt:run Primarily related to dbt run command or functionality execution:local Related to Local execution environment lgtm This PR has been approved by a maintainer parsing:custom Related to custom parsing, like custom DAG parsing, custom DBT parsing, etc size:L This PR changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants