Skip to content

Fix functools cache test issue#742

Merged
tatiana merged 1 commit into
mainfrom
fix-broken-tests
Dec 4, 2023
Merged

Fix functools cache test issue#742
tatiana merged 1 commit into
mainfrom
fix-broken-tests

Conversation

@tatiana
Copy link
Copy Markdown
Collaborator

@tatiana tatiana commented Dec 4, 2023

Fix exceptions raised for some versions of Python (e.g. 2.4) after prematurely merging #732, leading to the main branch becoming red

../../../.local/share/hatch/env/virtual/astronomer-cosmos/Za_bFbg4/tests.py3.8-2.5/lib/python3.8/site-packages/_pytest/assertion/rewrite.py:186: in exec_module
    exec(co, module.__dict__)
tests/test_example_dags_no_connections.py:4: in <module>
    from functools import cache
E   ImportError: cannot import name 'cache' from 'functools'

../../../.local/share/hatch/env/virtual/astronomer-cosmos/Za_bFbg4/tests.py3.8-2.5/lib/python3.8/site-packages/_pytest/assertion/rewrite.py:186: in exec_module
    exec(co, module.__dict__)
tests/test_example_dags_no_connections.py:4: in <module>
    from functools import cache
E   ImportError: cannot import name 'cache' from 'functools'
@tatiana tatiana requested a review from a team as a code owner December 4, 2023 11:51
@tatiana tatiana requested a review from a team December 4, 2023 11:51
@dosubot dosubot Bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Dec 4, 2023
@netlify
Copy link
Copy Markdown

netlify Bot commented Dec 4, 2023

👷 Deploy Preview for amazing-pothos-a3bca0 processing.

Name Link
🔨 Latest commit 9e266a5
🔍 Latest deploy log https://app.netlify.com/sites/amazing-pothos-a3bca0/deploys/656dbd2c3ff3c60008f01cca

@dosubot dosubot Bot added area:testing Related to testing, like unit tests, integration tests, etc execution:virtualenv Related to Virtualenv execution environment priority:high High priority issues are blocking or critical issues without a workaround and large impact labels Dec 4, 2023
@codecov
Copy link
Copy Markdown

codecov Bot commented Dec 4, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (aea4ee7) 92.99% compared to head (9e266a5) 92.99%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #742   +/-   ##
=======================================
  Coverage   92.99%   92.99%           
=======================================
  Files          55       55           
  Lines        2313     2313           
=======================================
  Hits         2151     2151           
  Misses        162      162           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tatiana tatiana merged commit e9950d7 into main Dec 4, 2023
@tatiana tatiana deleted the fix-broken-tests branch December 4, 2023 12:42
@tatiana tatiana added this to the 1.3.0 milestone Dec 4, 2023
arojasb3 pushed a commit to arojasb3/astronomer-cosmos that referenced this pull request Jul 14, 2024
Fix exceptions raised for some versions of Python (e.g. 2.4) after
prematurely merging astronomer#732, leading to the main branch becoming red
```
../../../.local/share/hatch/env/virtual/astronomer-cosmos/Za_bFbg4/tests.py3.8-2.5/lib/python3.8/site-packages/_pytest/assertion/rewrite.py:186: in exec_module
    exec(co, module.__dict__)
tests/test_example_dags_no_connections.py:4: in <module>
    from functools import cache
E   ImportError: cannot import name 'cache' from 'functools'
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:testing Related to testing, like unit tests, integration tests, etc execution:virtualenv Related to Virtualenv execution environment priority:high High priority issues are blocking or critical issues without a workaround and large impact size:S This PR changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant