Skip to content

Return code or error ignores WarnErrorOptions#692

Merged
tatiana merged 3 commits into
astronomer:mainfrom
adammarples:return-code-or-error
Nov 22, 2023
Merged

Return code or error ignores WarnErrorOptions#692
tatiana merged 3 commits into
astronomer:mainfrom
adammarples:return-code-or-error

Conversation

@adammarples
Copy link
Copy Markdown
Contributor

Description

Ignore WarnErrorOptions string in stdout from dbt-core, do not treat it as a failure

Related Issue(s)

Workaround for #642

Breaking Change?

Checklist

  • I have made corresponding changes to the documentation (if required)
  • I have added tests that prove my fix is effective or that my feature works

@adammarples adammarples requested a review from a team as a code owner November 20, 2023 09:46
@adammarples adammarples requested a review from a team November 20, 2023 09:46
@netlify
Copy link
Copy Markdown

netlify Bot commented Nov 20, 2023

👷 Deploy Preview for amazing-pothos-a3bca0 processing.

Name Link
🔨 Latest commit 45e7635
🔍 Latest deploy log https://app.netlify.com/sites/amazing-pothos-a3bca0/deploys/655d68714aa3530008d9fee4

@dosubot dosubot Bot added area:dependencies Related to dependencies, like Python packages, library versions, etc parsing:custom Related to custom parsing, like custom DAG parsing, custom DBT parsing, etc labels Nov 20, 2023
@dosubot dosubot Bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Nov 22, 2023
Copy link
Copy Markdown
Collaborator

@tatiana tatiana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick fix, @adammarples ! We're releasing this as part of Cosmos 1.2.5

@tatiana tatiana merged commit a52d1b7 into astronomer:main Nov 22, 2023
@tatiana tatiana added this to the 1.2.5 milestone Nov 22, 2023
@adammarples
Copy link
Copy Markdown
Contributor Author

Awesome @tatiana thank you!

This was referenced Nov 23, 2023
@tatiana
Copy link
Copy Markdown
Collaborator

tatiana commented Nov 23, 2023

1 similar comment
@tatiana
Copy link
Copy Markdown
Collaborator

tatiana commented Nov 23, 2023

arojasb3 pushed a commit to arojasb3/astronomer-cosmos that referenced this pull request Jul 14, 2024
Ignore `WarnErrorOptions` string in stdout from dbt-core, do not treat it
as a failure

Closes: astronomer#642
arojasb3 pushed a commit to arojasb3/astronomer-cosmos that referenced this pull request Jul 14, 2024
Bug fixes

* Fix running models that use alias while supporting dbt versions by
@binhnq94 in astronomer#662
* Make profiles_yml_path optional for ExecutionMode.DOCKER and
KUBERNETES by @MrBones757 in astronomer#681
* Prevent overriding dbt profile fields with profile args of type or
method by @jbandoro in astronomer#702
* Fix LoadMode.DBT_LS fail when dbt outputs WarnErrorOptions by
@adammarples in astronomer#692
* Add support for env vars in RenderConfig for dbt ls parsing by
@jbandoro in astronomer#690
* Add support for Kubernetes on_warning_callback by @david-mag in astronomer#673
* Fix ExecutionConfig.dbt_executable_path to use ``default_factory`` by
@jbandoro in astronomer#678

Others

* Docs fix: example DAG in the README and docs/index by @tatiana in astronomer#705
* Docs improvement: highlight DAG examples in README by @iancmoritz and
@jlaneve in astronomer#695

(cherry picked from commit 2878d6a)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:dependencies Related to dependencies, like Python packages, library versions, etc parsing:custom Related to custom parsing, like custom DAG parsing, custom DBT parsing, etc size:XS This PR changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants