Skip to content

Release 1.2.3#665

Merged
tatiana merged 2 commits into
release-1.2from
release-1.2.3
Nov 9, 2023
Merged

Release 1.2.3#665
tatiana merged 2 commits into
release-1.2from
release-1.2.3

Conversation

@tatiana
Copy link
Copy Markdown
Collaborator

@tatiana tatiana commented Nov 9, 2023

Bug fix

If execution_config was reused, Cosmos 1.2.2 would raise:

```
astronomer-cosmos/dags/basic_cosmos_task_group.py
Traceback (most recent call last):
  File "/Users/tati/Code/cosmos-clean/astronomer-cosmos/venv-38/lib/python3.8/site-packages/airflow/models/dagbag.py", line 343, in parse
    loader.exec_module(new_module)
  File "<frozen importlib._bootstrap_external>", line 848, in exec_module
  File "<frozen importlib._bootstrap>", line 219, in _call_with_frames_removed
  File "/Users/tati/Code/cosmos-clean/astronomer-cosmos/dags/basic_cosmos_task_group.py", line 74, in <module>
    basic_cosmos_task_group()
  File "/Users/tati/Code/cosmos-clean/astronomer-cosmos/venv-38/lib/python3.8/site-packages/airflow/models/dag.py", line 3817, in factory
    f(**f_kwargs)
  File "/Users/tati/Code/cosmos-clean/astronomer-cosmos/dags/basic_cosmos_task_group.py", line 54, in basic_cosmos_task_group
    orders = DbtTaskGroup(
  File "/Users/tati/Code/cosmos-clean/astronomer-cosmos/cosmos/airflow/task_group.py", line 26, in __init__
    DbtToAirflowConverter.__init__(self, *args, **specific_kwargs(**kwargs))
  File "/Users/tati/Code/cosmos-clean/astronomer-cosmos/cosmos/converter.py", line 113, in __init__
    raise CosmosValueError(
cosmos.exceptions.CosmosValueError: ProjectConfig.dbt_project_path is mutually exclusive with RenderConfig.dbt_project_path and ExecutionConfig.dbt_project_path.If using RenderConfig.dbt_project_path or ExecutionConfig.dbt_project_path, ProjectConfig.dbt_project_path should be None
```

This has been raised by an Astro customer and our field engineer, who
tried to run: https://github.com/astronomer/cosmos-demo

(cherry picked from commit 9001c98)
Bug fixes

* Fix reusing config accross TaskGroups/DAGs by @tatiana in #664
@tatiana tatiana requested a review from a team as a code owner November 9, 2023 16:48
@tatiana tatiana requested a review from a team November 9, 2023 16:48
@dosubot dosubot Bot added area:config Related to configuration, like YAML files, environment variables, or executer configuration priority:high High priority issues are blocking or critical issues without a workaround and large impact labels Nov 9, 2023
@tatiana tatiana merged commit 6fa970f into release-1.2 Nov 9, 2023
@tatiana tatiana deleted the release-1.2.3 branch November 9, 2023 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:config Related to configuration, like YAML files, environment variables, or executer configuration priority:high High priority issues are blocking or critical issues without a workaround and large impact

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants