Skip to content

Remove Pydantic dependency#654

Closed
jlaneve wants to merge 3 commits into
mainfrom
remove-pydantic
Closed

Remove Pydantic dependency#654
jlaneve wants to merge 3 commits into
mainfrom
remove-pydantic

Conversation

@jlaneve
Copy link
Copy Markdown
Contributor

@jlaneve jlaneve commented Nov 6, 2023

Description

This PR removes the Pydantic dependency from Cosmos. It appears we're no longer using it.

Related Issue(s)

closes #651

Breaking Change?

No

Checklist

  • I have made corresponding changes to the documentation (if required)
  • I have added tests that prove my fix is effective or that my feature works

@jlaneve jlaneve requested a review from a team as a code owner November 6, 2023 20:39
@jlaneve jlaneve requested a review from a team November 6, 2023 20:39
@netlify
Copy link
Copy Markdown

netlify Bot commented Nov 6, 2023 •
edited
Loading

👷 Deploy Preview for amazing-pothos-a3bca0 processing.

Name Link
🔨 Latest commit 64a2b31
🔍 Latest deploy log https://app.netlify.com/sites/amazing-pothos-a3bca0/deploys/6567801ba9ea5e0008482fba

@tatiana tatiana mentioned this pull request Nov 7, 2023
Closed
@tatiana
Copy link
Copy Markdown
Collaborator

tatiana commented Nov 7, 2023

@jlaneve It seems the Airflow 2.6 tests are failing if we remove the Pydantic dep:

Example:

= 23 failed, 152 passed, 18 deselected, 2 xfailed, 1 warning, 75 errors in 21.08s =

https://github.com/astronomer/astronomer-cosmos/actions/runs/6776766746/job/18418976543?pr=654

We could consider only installing this version of Pydantic for this particular version of Airflow when running its tests, WDYT?

@tatiana tatiana added the area:dependencies Related to dependencies, like Python packages, library versions, etc label Nov 9, 2023
@pixie79 pixie79 mentioned this pull request Nov 29, 2023
Closed
2 tasks
@pixie79
Copy link
Copy Markdown

pixie79 commented Nov 29, 2023

@jlaneve @tatiana I think I have the correct fix for this PR - #725 It removes pydantic as a dependency except if the apache-airflow version is 2.6.* which I believe is the desired outcome?

@dosubot dosubot Bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Nov 29, 2023
@pixie79 pixie79 mentioned this pull request Dec 2, 2023
Merged
2 tasks
@tatiana tatiana closed this in #736 Dec 4, 2023
tatiana pushed a commit that referenced this pull request Dec 4, 2023
Optional pydantic (#736)
abeb15c 
Converts pydantic to being optional, as it is required for Airflow 2.6
but not others.

Closes #725 
Closes #654
arojasb3 pushed a commit to arojasb3/astronomer-cosmos that referenced this pull request Jul 14, 2024
@arojasb3
Optional pydantic (astronomer#736)
7456681 
Converts pydantic to being optional, as it is required for Airflow 2.6
but not others.

Closes astronomer#725 
Closes astronomer#654
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

area:dependencies Related to dependencies, like Python packages, library versions, etc size:XS This PR changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Pydantic

3 participants

@jlaneve @tatiana @pixie79