Enable type checks (MyPy) in the CI#510
Merged
Merged
Conversation
👷 Deploy Preview for amazing-pothos-a3bca0 processing.
|
tatiana
commented
Sep 5, 2023
tatiana
force-pushed
the
enable-mypy-in-ci
branch
from
04b82d3 to
f633919
Compare
tatiana
force-pushed
the
enable-mypy-in-ci
branch
from
f633919 to
4844d84
Compare
Merged
(cherry picked from commit 06c483d8bff403a552518a9944572d26aa684039)
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #510 +/- ##
==========================================
+ Coverage 91.30% 91.49% +0.18%
==========================================
Files 49 49
Lines 1921 1928 +7
==========================================
+ Hits 1754 1764 +10
+ Misses 167 164 -3
☔ View full report in Codecov by Sentry. |
As observed in: #482 The following exception was raised: build of https://github.com/pre-commit/mirrors-mypy:types-PyYAML,types-attrs,attrs,types-requests,types-python-dateutil,apache-airflow@v1.5.1 for python@python3 exceeds tier max size 250MiB: 262.2MiB So we disabled MyPy checks as part of #485
File "/home/runner/.local/share/hatch/env/virtual/astronomer-cosmos/Za_bFbg4/tests.py3.10-2.6/lib/python3.10/site-packages/openlineage/common/provider/dbt/processor.py", line 568, in extract_adapter_type
raise NotImplementedError(
NotImplementedError: Only `bigquery`,`snowflake`,`redshift`,`spark`,`***` adapters are supported right now. Passed databricks
tatiana
force-pushed
the
enable-mypy-in-ci
branch
from
4003354 to
6040e8e
Compare
harels
reviewed
Sep 6, 2023
harels
approved these changes
Sep 6, 2023
harels
left a comment
harels
left a comment
Contributor
There was a problem hiding this comment.
nice! one minor comment, but LGTM
harels
pushed a commit
that referenced
this pull request
Sep 6, 2023
Fix an issue introduced by #510, which only surfaced in the CI after the PR was merged.
tatiana
added a commit
that referenced
this pull request
Sep 6, 2023
**Features** * Support dbt global flags (via dbt_cmd_global_flags in operator_args) by @tatiana in #469 * Support parsing DAGs when there are no connections by @jlaneve in #489 **Enhancements** * Hide sensitive field when using BigQuery keyfile_dict profile mapping by @jbandoro in #471 * Consistent Airflow Dataset URIs, inlets and outlets with `Openlineage package <https://pypi.org/project/openlineage-integration-common/>`_ by @tatiana in #485. `Read more <https://astronomer.github.io/astronomer-cosmos/configuration/lineage.html>`_. * Refactor ``LoadMethod.DBT_LS`` to run from a temporary directory with symbolic links by @tatiana in #488 * Run ``dbt deps`` when using ``LoadMethod.DBT_LS`` by @DanMawdsleyBA in #481 * Update Cosmos log color to purple by @harels in #494 * Change operators to log ``dbt`` commands output as opposed to recording to XCom by @tatiana in #513 **Bug fixes** * Fix bug on select node add exclude selector subset ids logic by @jensenity in #463 * Refactor dbt ls to run from a temporary directory, to avoid Read-only file system errors during DAG parsing, by @tatiana in #414 * Fix profile_config arg in DbtKubernetesBaseOperator by @david-mag in #505 * Fix SnowflakePrivateKeyPemProfileMapping private_key reference by @nacpacheco in #501 * Fix incorrect temporary directory creation in VirtualenvOperator init by @tatiana in #500 * Fix log propagation issue by @tatiana in #498 * Fix PostgresUserPasswordProfileMapping to retrieve port from connection by @jlneve in #511 **Others** * Docs: Fix RenderConfig load argument by @jbandoro in #466 * Enable CI integration tests from external forks by @tatiana in #458 * Improve CI tests runtime by @tatiana in #457 * Change CI to run coverage after tests pass by @tatiana in #461 * Fix forks code revision in code coverage by @tatiana in #472 * [pre-commit.ci] pre-commit autoupdate by @pre-commit-ci in #467 * Drop support to Python 3.7 in the CI test matrix by @harels in #490 * Add Airflow 2.7 to the CI test matrix by @tatiana in #487 * Add MyPy type checks to CI since we exceeded pre-commit disk quota usage by @tatiana in #510
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We had to disable MyPy checks from the pre-commit hook because we were reaching a quota from the pre-commit service:
As observed in #482.
This PR re-enables MyPy checks but in the CI.
Bonus: Fix Openlineage import error handling