Skip to content

Fix incorrect temporary directory creation in VirtualenvOperator init #500

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tatiana merged 1 commit into from
Aug 30, 2023
Merged

Fix incorrect temporary directory creation in VirtualenvOperator init #500

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion cosmos/operators/virtualenv.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ def __init__(
self.py_requirements = py_requirements or []
self.py_system_site_packages = py_system_site_packages
super().__init__(**kwargs)
self._venv_tmp_dir = TemporaryDirectory()
self._venv_tmp_dir: None | TemporaryDirectory[str] = None

@cached_property
def venv_dbt_path(
Expand Down
2 changes: 2 additions & 0 deletions tests/operators/test_virtualenv.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,8 @@ def test_run_command(
py_system_site_packages=False,
py_requirements=["dbt-postgres==1.6.0b1"],
)
assert venv_operator._venv_tmp_dir is None # Otherwise we are creating empty directories during DAG parsing time
# and not deleting them
venv_operator.run_command(cmd=["fake-dbt", "do-something"], env={}, context={})
run_command_args = mock_subprocess_hook.run_command.call_args_list
assert len(run_command_args) == 3
Expand Down