Skip to content

update graph parsing mode when virtualenv is selected #402

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jlaneve merged 7 commits into from
Jul 27, 2023
Merged

update graph parsing mode when virtualenv is selected #402

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
f94033e
Update graph.py
CorsettiS Jul 27, 2023
7c045f8
🎨 [pre-commit.ci] Auto format from pre-commit.com hooks
pre-commit-ci[bot] Jul 27, 2023
4080ef2
change mock_test of virtualenv for mock_load_via_custom_parser
CorsettiS Jul 27, 2023
a9bbbaa
🎨 [pre-commit.ci] Auto format from pre-commit.com hooks
pre-commit-ci[bot] Jul 27, 2023
d1a2801
Merge branch 'main' into patch-1
jlaneve Jul 27, 2023
fc7553a
Merge branch 'main' into patch-1
jlaneve Jul 27, 2023
d109842
Merge branch 'main' into patch-1
jlaneve Jul 27, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 1 addition & 4 deletions cosmos/dbt/graph.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,10 +102,7 @@ def load(
if self.project.is_manifest_available():
self.load_from_dbt_manifest()
return
elif (
execution_mode in (ExecutionMode.LOCAL, ExecutionMode.VIRTUALENV)
and self.project.is_profile_yml_available()
):
elif execution_mode == ExecutionMode.LOCAL and self.project.is_profile_yml_available():
try:
self.load_via_dbt_ls()
return
Expand Down
2 changes: 1 addition & 1 deletion tests/dbt/test_graph.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,7 @@ def test_load_manifest_with_manifest(mock_load_from_dbt_manifest):
"exec_mode,method,expected_function",
[
(ExecutionMode.LOCAL, LoadMode.AUTOMATIC, "mock_load_via_dbt_ls"),
(ExecutionMode.VIRTUALENV, LoadMode.AUTOMATIC, "mock_load_via_dbt_ls"),
(ExecutionMode.VIRTUALENV, LoadMode.AUTOMATIC, "mock_load_via_custom_parser"),
(ExecutionMode.KUBERNETES, LoadMode.AUTOMATIC, "mock_load_via_custom_parser"),
(ExecutionMode.DOCKER, LoadMode.AUTOMATIC, "mock_load_via_custom_parser"),
(ExecutionMode.LOCAL, LoadMode.DBT_LS, "mock_load_via_dbt_ls"),
Expand Down