Skip to content

Replace tilt for docker compose in the contributing docs#355

Merged
jlaneve merged 2 commits into
astronomer:mainfrom
CorsettiS:docs_change
Jul 4, 2023
Merged

Replace tilt for docker compose in the contributing docs#355
jlaneve merged 2 commits into
astronomer:mainfrom
CorsettiS:docs_change

Conversation

@CorsettiS
Copy link
Copy Markdown
Contributor

Description

From my personal experience using tilt, it did not work locally, while the classic docker compose command worked fine. I would suggest to change it to docker compose to simplify development, although it is understandable if the project wants to stick with tilt since it should, in theory simplify some of the overhead.

Related Issue(s)

this is a fix for a issue I was facing #342

Breaking Change?

No

Checklist

  • I have made corresponding changes to the documentation (if required)
  • I have added tests that prove my fix is effective or that my feature works

@CorsettiS CorsettiS requested a review from a team as a code owner June 30, 2023 10:39
@CorsettiS CorsettiS requested a review from a team June 30, 2023 10:39
@netlify
Copy link
Copy Markdown

netlify Bot commented Jun 30, 2023

👷 Deploy Preview for amazing-pothos-a3bca0 processing.

Name Link
🔨 Latest commit 19c1cba
🔍 Latest deploy log https://app.netlify.com/sites/amazing-pothos-a3bca0/deploys/649eb0ee5955520008e57af9

@codecov
Copy link
Copy Markdown

codecov Bot commented Jun 30, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (35293aa) 88.94% compared to head (19c1cba) 88.94%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #355   +/-   ##
=======================================
  Coverage   88.94%   88.94%           
=======================================
  Files          39       39           
  Lines        1302     1302           
=======================================
  Hits         1158     1158           
  Misses        144      144           

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Copy Markdown
Contributor

@jlaneve jlaneve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thank you! The big thing tilt gives us is the ability to hot rebuild images when you change requirements, etc. But I think the trade off in complexity isn’t worth it, so thank you for putting this PR together.

@jlaneve jlaneve merged commit 949c185 into astronomer:main Jul 4, 2023
tatiana added a commit that referenced this pull request Sep 18, 2025
[Giovanni Corsetti
Silva](https://www.linkedin.com/in/giovanni-corsetti/) (@corsettigyg
@CorsettiS @giovannicorsetti) is a Core Data Platform Data Engineer at
[Get Your Guide](https://www.getyourguide.com/). He's a Brazilian based
in Berlin (Germany) and has been an early adopter of Cosmos, using it
regularly throughout his career.

Not only has he been using Cosmos since the early stages, but he has
consistently improved Cosmos since April 2023:

<img width="494" height="249" alt="Screenshot 2025-09-17 at 16 39 49"
src="https://github.com/user-attachments/assets/ff9b0055-7df6-47a4-8efa-83a30d5aee99"
/>
] m. ,
<img width="492" height="252" alt="Screenshot 2025-09-17 at 16 40 11"
src="https://github.com/user-attachments/assets/8402d883-eff4-46aa-9ae7-afe35bd39a6e"
/>

<img width="499" height="256" alt="Screenshot 2025-09-17 at 16 39 23"
src="https://github.com/user-attachments/assets/c6b84245-aae1-46e6-99e3-552553619dd9"
/>

His contributions include new features, enhancements, bug fixes and also
improvements on the local dev setup, as it can see in some of the many
contributions he's done to the project so far:

* #1787
* #1761
* #1695 
* #1693 
* #1663
* #1571
* #1449
* #1099
* #1091
* #419
* #402
* #355 
* #354 
* #225 

Additionally, he has been interacting with users in the #airflow-dbt
Slack channel in a very collaborative and supportive way.

We want to promote him as a Cosmos committer and maintainer for all
these, recognising his constant efforts and achievements towards our
community. Thank you very much, @corsettigyg!

From this moment, you have write permissions on the repo:
<img width="884" height="93" alt="Screenshot 2025-09-18 at 14 34 07"
src="https://github.com/user-attachments/assets/abcc8c42-87cf-4b32-a7be-81127190d164"
/>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants