Restore functionality to dynamically resolved user-provided node types#2608
Merged
tatiana merged 2 commits intoMay 1, 2026
Merged
Conversation
jroachgolf84
requested review from
a team,
corsettigyg,
dwreeves and
jbandoro
as code owners
2 tasks
2 tasks
tatiana
pushed a commit
that referenced
this pull request
Apr 27, 2026
The `example_cosmos_sources` DAG in the `dev/dags/example_cosmos_sources.py` file was improperly mapped to the `jaffle_shop` project, rather than the `altered_jaffle_shop` project. The `ProfileConfig` in the DAG pointed to `altered_jaffle_shop`, and the `jaffle_shop` had no dbt Sources to render. Thus, it seemed as if this change was needed. The work done in #2608 will ensure that these dbt Sources are properly rendered using the `node_converters` supplied in the DAG itself. ## Testing These changes were tested E2E by spinning up Airflow and testing the DAG.
tatiana
changed the title
fix/response-dynamically-resolved-node-types: Restore functionality to dynamically resolved user-provided node types
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2608 +/- ##
=======================================
Coverage 98.05% 98.05%
=======================================
Files 104 104
Lines 7762 7765 +3
=======================================
+ Hits 7611 7614 +3
Misses 151 151 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
tatiana
approved these changes
May 1, 2026
Collaborator
tatiana
left a comment
tatiana
left a comment
There was a problem hiding this comment.
This looks great, @jroachgolf84 , thanks a lot for the improvements!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Per issue #2393,
DbtResourceType.EXPOSUREnodes defined inrender_config.node_convertersare silently ignored during DAG rendering, producing the following warning instead:Previously, #2576 was opened to address this only for
DbtResourceType.EXPOSUREs. However, @tatiana called out that this functionality was actually deprecated for more than just Exposures. Thus, this PR was created to ensure that all node types withnode_convertersspecified by the user are properly rendered using their desired function.Testing
This was tested with the addition of two new unit-tests (as well as the successful execution of previous unit-tests). There were:
test_generate_task_or_group_with_dynamic_node_type_and_convertertest_generate_task_or_group_with_dynamic_node_type_no_converter_returns_noneThese changes were also tested E2E using the
example_cosmos_sourcesDAG. Before this change was made, the source and exposure node types were not rendered in the UI, despite being explicitly added to theRenderConfig.node_converters. Following the change, those nodes were properly rendered. See the image below.Related Issue(s)
closes: #2393
Breaking Change?
No, this is not a breaking change.
Checklist