⬆ [pre-commit.ci] pre-commit autoupdate#2530
Closed
pre-commit-ci[bot] wants to merge 2 commits into
Closed
Conversation
updates: - [github.com/astral-sh/ruff-pre-commit: v0.15.8 → v0.15.9](astral-sh/ruff-pre-commit@v0.15.8...v0.15.9) - [github.com/pre-commit/mirrors-mypy: v1.19.1 → v1.20.0](pre-commit/mirrors-mypy@v1.19.1...v1.20.0)
pre-commit-ci
Bot
requested review from
a team,
corsettigyg,
dwreeves and
jbandoro
as code owners
tatiana
reviewed
Apr 7, 2026
Collaborator
tatiana
left a comment
tatiana
left a comment
There was a problem hiding this comment.
Apparently this upgrade will require some code-changes / type annotations changes in Cosmos - we'll likely have bandwith to work on it for 1.14.1.
Contributor
|
We would actually like to disable pre-commit bot suggesting these upgrades as it has not setting to apply for a 7 day cooldown as per our policy. We have added PR #2517 to use dependabot to suggest pre-commit hook upgrades. e.g. #2518 was a PR created by dependabot to upgrade the black pre-commit hook. I don't have permissions to disable this pre-commit integration. @tatiana do you have those or know who can help us here? |
tatiana
added a commit
that referenced
this pull request
Apr 8, 2026
Currently `pre-commit-ci[bot]` opens PR suggestions in Github and we would like to disable them, since it does not respect Astronomer's 7 day cooldown policy. We recently updated Dependabot to manage pre-commit upgrades, so we are safe to disable this other configuration. Related: #2530
Collaborator
Thanks for the explanation, @pankajkoti ! I believe this should tackle disabling these automatic PRs from |
tatiana
added a commit
that referenced
this pull request
Apr 8, 2026
Currently, `pre-commit-ci[bot]` opens PR suggestions on GitHub, and we would like to disable them because it does not respect Astronomer's 7-day cooldown policy. We recently updated Dependabot to manage pre-commit upgrades, so we can safely disable this other configuration. Related: #2530 Related: #2530 Unfortunately, it seems that, to date, pre-commit[ci] does not offer [granularity to disable only the autoupdate PRs](pre-commit/pre-commit#2670). It is also [not possible to skip it](ddf8375), since it is not a pre-commit job. The alternative to the change in this PR would be to remove `pre-commit[ci]` as a GitHub app altogether. This would, however, have the downside of not running pre-commit checks in the CI as we do now, which are quite useful. Therefore, we decided to reduce the frequency of how often this happens - for now - until we have a better solution. Also fixes failing `pre-commit` check: ``` ❯ Just pulled the latest changes from main, getting: ruff check....................................................................Failed - hook id: ruff-check - exit code: 1 F821 Undefined name `cosmos` --> tests/test_log.py:45:25 | 43 | def test_rich_logging_none_message(monkeypatch, caplog): 44 | """CosmosRichLogger should not crash when record.msg is None.""" 45 | monkeypatch.setattr(cosmos.log, "rich_logging", True) | ^^^^^^ 46 | logger = get_logger("test-none-msg") 47 | with caplog.at_level("INFO"): | ``` https://results.pre-commit.ci/run/github/577757880/1775638428.KyFU_uV_Q-id7x3hn2tGVg
pankajkoti
pushed a commit
that referenced
this pull request
Apr 23, 2026
Currently, `pre-commit-ci[bot]` opens PR suggestions on GitHub, and we would like to disable them because it does not respect Astronomer's 7-day cooldown policy. We recently updated Dependabot to manage pre-commit upgrades, so we can safely disable this other configuration. Related: #2530 Related: #2530 Unfortunately, it seems that, to date, pre-commit[ci] does not offer [granularity to disable only the autoupdate PRs](pre-commit/pre-commit#2670). It is also [not possible to skip it](ddf8375), since it is not a pre-commit job. The alternative to the change in this PR would be to remove `pre-commit[ci]` as a GitHub app altogether. This would, however, have the downside of not running pre-commit checks in the CI as we do now, which are quite useful. Therefore, we decided to reduce the frequency of how often this happens - for now - until we have a better solution. Also fixes failing `pre-commit` check: ``` ❯ Just pulled the latest changes from main, getting: ruff check....................................................................Failed - hook id: ruff-check - exit code: 1 F821 Undefined name `cosmos` --> tests/test_log.py:45:25 | 43 | def test_rich_logging_none_message(monkeypatch, caplog): 44 | """CosmosRichLogger should not crash when record.msg is None.""" 45 | monkeypatch.setattr(cosmos.log, "rich_logging", True) | ^^^^^^ 46 | logger = get_logger("test-none-msg") 47 | with caplog.at_level("INFO"): | ``` https://results.pre-commit.ci/run/github/577757880/1775638428.KyFU_uV_Q-id7x3hn2tGVg (cherry picked from commit 513f0ed)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
updates: