-
Notifications
You must be signed in to change notification settings - Fork 295
[Docs] Getting Started - Table of Contents restructure #2408
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
13a1839
first pass architecture
lzdanski 1383081
Merge branch 'astronomer:main' into getting-started-toc-draft
lzdanski 51cc1f8
First pass reformat
lzdanski 1c140fc
delete test pages and directory
lzdanski 56cd870
make flat navigation
lzdanski 2eeefae
separate execution modes
lzdanski d5ea1fd
🎨 [pre-commit.ci] Auto format from pre-commit.com hooks
pre-commit-ci[bot] fd288b3
Merge branch 'astronomer:main' into getting-started-toc-draft
lzdanski 7cc2abf
edit titles and sidebar
lzdanski 03abd0f
remove placeholder page
lzdanski 2906d88
update toc nav
lzdanski File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -2,7 +2,7 @@ | |
|
|
||
| .. toctree:: | ||
| :hidden: | ||
| :maxdepth: 2 | ||
| :maxdepth: 1 | ||
| :caption: Contents: | ||
|
|
||
| Home <self> | ||
|
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This currently renders:
Execution Modes
I think this part of the table of contents can cause confusion and reduce scannability for new users. A few concerns:
On the inconsistent naming:
On (4), concept x implementation, the list mixes:
This makes the mental model unclear. A user might reasonably ask:
Lastly, on (5), for someone just trying to run dbt in Airflow, seeing:
…is overwhelming and abstract.
Instead of a smooth getting-started experience, it introduces internal terminology before grounding the user in the task.
Maybe we should break it down into two parts:
dbt Installation
ProjectConfig.install_dbt_deps)Running dbt in Airflow