Skip to content

Refactor _handle_no_precursors_or_descendants to reduce code complexity #2400

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pankajkoti merged 3 commits into from
Feb 24, 2026
Merged

Refactor _handle_no_precursors_or_descendants to reduce code complexity #2400

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
68c8a21
Refactor _handle_no_precursors_or_descendants to reduce code complexity
pankajkoti Feb 24, 2026
1d542f1
Remove noqa from _should_include_node
pankajkoti Feb 24, 2026
df6f6b0
Update cosmos/dbt/selector.py
pankajkoti Feb 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
41 changes: 18 additions & 23 deletions cosmos/dbt/selector.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -443,28 +443,24 @@ def load_from_statement(self, statement: str) -> None:
else:
self._handle_no_precursors_or_descendants(item, node_name)

# TODO: Refactor this method to remove the noqa: C901 in a separate PR.
def _handle_no_precursors_or_descendants(self, item: str, node_name: str) -> None: # noqa: C901
if node_name.startswith(PATH_SELECTOR):
self._parse_path_selector(item)
elif "/" in node_name:
def _handle_no_precursors_or_descendants(self, item: str, node_name: str) -> None:
prefix_handlers = {
PATH_SELECTOR: self._parse_path_selector,
TAG_SELECTOR: self._parse_tag_selector,
CONFIG_SELECTOR: self._parse_config_selector,
SOURCE_SELECTOR: self._parse_source_selector,
EXPOSURE_SELECTOR: self._parse_exposure_selector,
PACKAGE_SELECTOR: self._parse_package_selector,
RESOURCE_TYPE_SELECTOR: self._parse_resource_type_selector,
EXCLUDE_RESOURCE_TYPE_SELECTOR: self._parse_exclude_resource_type_selector,
FQN_SELECTOR: self._parse_fqn_selector,
}
for prefix, handler in prefix_handlers.items():
if node_name.startswith(prefix):
handler(item)
return
if "/" in node_name:
self._parse_path_selector(f"{PATH_SELECTOR}{node_name}")
Comment thread
pankajkoti marked this conversation as resolved.
elif node_name.startswith(TAG_SELECTOR):
self._parse_tag_selector(item)
elif node_name.startswith(CONFIG_SELECTOR):
self._parse_config_selector(item)
elif node_name.startswith(SOURCE_SELECTOR):
self._parse_source_selector(item)
elif node_name.startswith(EXPOSURE_SELECTOR):
self._parse_exposure_selector(item)
elif node_name.startswith(PACKAGE_SELECTOR):
self._parse_package_selector(item)
elif node_name.startswith(RESOURCE_TYPE_SELECTOR):
self._parse_resource_type_selector(item)
elif node_name.startswith(EXCLUDE_RESOURCE_TYPE_SELECTOR):
self._parse_exclude_resource_type_selector(item)
elif node_name.startswith(FQN_SELECTOR):
self._parse_fqn_selector(item)
elif self._is_bare_identifier(node_name):
self._parse_bare_identifier(node_name)
else:
Expand Down Expand Up @@ -636,8 +632,7 @@ def _should_include_based_on_non_meta_and_non_tag_config(self, node: DbtNode, co
return False
return True

# TODO: Refactor this method to remove the noqa: C901 in a separate PR.
Comment thread
pankajkoti marked this conversation as resolved.
def _should_include_node(self, node_id: str, node: DbtNode) -> bool: # noqa: C901
def _should_include_node(self, node_id: str, node: DbtNode) -> bool:
"""
Checks if a single node should be included. Only runs once per node with caching."""
logger.debug("Inspecting if the node <%s> should be included.", node_id)
Expand Down