Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions cosmos/operators/watcher.py
Original file line number Diff line number Diff line change
Expand Up @@ -241,6 +241,8 @@ def __init__(
profile_config=profile_config,
project_dir=project_dir,
profiles_dir=profiles_dir,
producer_task_id=producer_task_id,
deferrable=deferrable,
**kwargs,
)

Expand Down
17 changes: 14 additions & 3 deletions tests/operators/test_watcher.py
Original file line number Diff line number Diff line change
Expand Up @@ -281,11 +281,11 @@ def test_dbt_producer_watcher_operator_skips_retry_attempt(caplog):
({"status": "success", "reason": "model_not_run"}, None),
(
{"status": "failed", "reason": "model_failed"},
"dbt model 'model.pkg.m' failed. Review the producer task 'dbt_producer_watcher' logs for details.",
"dbt model 'model.pkg.m' failed. Review the producer task 'dbt_producer_watcher_operator' logs for details.",
),
(
{"status": "failed", "reason": "producer_failed"},
"Watcher producer task 'dbt_producer_watcher' failed before reporting model results. Check its logs for the underlying error.",
"Watcher producer task 'dbt_producer_watcher_operator' failed before reporting model results. Check its logs for the underlying error.",
),
],
)
Expand Down Expand Up @@ -810,7 +810,7 @@ def make_sensor(self, **kwargs):
task_id="model.my_model",
project_dir="/tmp/project",
profile_config=None,
deferrable=True,
deferrable=kwargs.pop("deferrable", True),
**kwargs,
)

Expand Down Expand Up @@ -1205,6 +1205,17 @@ def test_sensor_not_deferred(self, mock_poke):
sensor.execute(context=context)
mock_poke.assert_called_once()

@patch("cosmos.operators.watcher.DbtConsumerWatcherSensor.poke")
def test_deferrable_false_via_constructor_does_not_defer(self, mock_poke):
"""operator_args={'deferrable': False} is respected: sensor created with deferrable=False does not defer."""
mock_poke.return_value = True
sensor = self.make_sensor(deferrable=False)
assert sensor.deferrable is False
context = {"run_id": "run_id", "task_instance": Mock()}
sensor.execute(context=context)
mock_poke.assert_called_once()
Comment thread
pankajkoti marked this conversation as resolved.
# No TaskDeferred raised: sensor ran synchronously and completed

@pytest.mark.parametrize(
"mock_event",
[
Expand Down