Skip to content

Add targeted type: ignore for untyped decorators to fix mypy errors #2174

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pankajastro merged 1 commit into from
Dec 2, 2025
Merged

Add targeted type: ignore for untyped decorators to fix mypy errors #2174

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions cosmos/dbt/parser/output.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,8 +49,8 @@ def parse_number_of_warnings_subprocess(result: FullOutputSubprocessResult) -> i
removed_in="2.0",
current_version=cosmos_version,
details="Use the `cosmos.dbt.runner.parse_number_of_warnings` instead.",
) # type: ignore[misc]
def parse_number_of_warnings_dbt_runner(result: dbtRunnerResult) -> int: # type: ignore[misc]
) # type: ignore[untyped-decorator]
def parse_number_of_warnings_dbt_runner(result: dbtRunnerResult) -> int:
"""Parses a dbt runner result and returns the number of warnings found. This only works for dbtRunnerResult
from invoking dbt build, compile, run, seed, snapshot, test, or run-operation.
"""
Expand Down Expand Up @@ -121,7 +121,7 @@ def clean_line(line: str) -> str:
removed_in="2.0",
current_version=cosmos_version,
details="Use the `cosmos.dbt.runner.extract_message_by_status` instead.",
) # type: ignore[misc]
) # type: ignore[untyped-decorator]
def extract_dbt_runner_issues(
result: dbtRunnerResult, status_levels: list[str] = ["warn"]
) -> Tuple[List[str], List[str]]: # type: ignore[misc]
Comment thread
pankajastro marked this conversation as resolved.
Expand Down
16 changes: 8 additions & 8 deletions cosmos/plugin/airflow2.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -133,15 +133,15 @@ def create_blueprint(
# Make sure the static folder is not overwritten, as we want to use it.
return super().create_blueprint(appbuilder, endpoint=endpoint, static_folder=self.static_folder) # type: ignore[no-any-return]

@expose("/dbt_docs") # type: ignore[misc]
@has_access(MENU_ACCESS_PERMISSIONS) # type: ignore[misc]
@expose("/dbt_docs") # type: ignore[untyped-decorator]
@has_access(MENU_ACCESS_PERMISSIONS) # type: ignore[untyped-decorator]
def dbt_docs(self) -> str:
if dbt_docs_dir is None:
return self.render_template("dbt_docs_not_set_up.html") # type: ignore[no-any-return,no-untyped-call]
return self.render_template("dbt_docs.html") # type: ignore[no-any-return,no-untyped-call]

@expose("/dbt_docs_index.html") # type: ignore[misc]
@has_access(MENU_ACCESS_PERMISSIONS) # type: ignore[misc]
@expose("/dbt_docs_index.html") # type: ignore[untyped-decorator]
@has_access(MENU_ACCESS_PERMISSIONS) # type: ignore[untyped-decorator]
def dbt_docs_index(self) -> Tuple[str, int, Dict[str, Any]]:
if dbt_docs_dir is None:
abort(404)
Expand All @@ -153,8 +153,8 @@ def dbt_docs_index(self) -> Tuple[str, int, Dict[str, Any]]:
html = html.replace("</head>", f"{IFRAME_SCRIPT}</head>")
return html, 200, {"Content-Security-Policy": "frame-ancestors 'self'"}

@expose("/catalog.json") # type: ignore[misc]
@has_access(MENU_ACCESS_PERMISSIONS) # type: ignore[misc]
@expose("/catalog.json") # type: ignore[untyped-decorator]
@has_access(MENU_ACCESS_PERMISSIONS) # type: ignore[untyped-decorator]
def catalog(self) -> Tuple[str, int, Dict[str, Any]]:
if dbt_docs_dir is None:
abort(404)
Expand All @@ -165,8 +165,8 @@ def catalog(self) -> Tuple[str, int, Dict[str, Any]]:
else:
return data, 200, {"Content-Type": "application/json"}

@expose("/manifest.json") # type: ignore[misc]
@has_access(MENU_ACCESS_PERMISSIONS) # type: ignore[misc]
@expose("/manifest.json") # type: ignore[untyped-decorator]
@has_access(MENU_ACCESS_PERMISSIONS) # type: ignore[untyped-decorator]
def manifest(self) -> Tuple[str, int, Dict[str, Any]]:
if dbt_docs_dir is None:
abort(404)
Expand Down