Skip to content

move debug logs to debug channel#2163

Closed
matthieuauger wants to merge 1 commit into
astronomer:mainfrom
nova-data-analytics:debug-logs-less-verbose
Closed

move debug logs to debug channel#2163
matthieuauger wants to merge 1 commit into
astronomer:mainfrom
nova-data-analytics:debug-logs-less-verbose

Conversation

@matthieuauger
Copy link
Copy Markdown

@matthieuauger matthieuauger commented Nov 25, 2025

Description

These logs are displayed on every task multiple times. They hide meaningful information logged in the tasks.
There are more useful when trying to debug performance issues.

Here is an example of what is shown in my tasks, this makes the logs less readable

image

Related Issue(s)

closes #2069

Breaking Change?

This could be a breaking change is anyone is using these logs programatically but I doubt that is the case

Checklist

  • I have made corresponding changes to the documentation (if required)
  • I have added tests that prove my fix is effective or that my feature works

Copy link
Copy Markdown
Contributor

@pankajastro pankajastro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! It looks like the CI checks are failing—could you please take a look and fix them?

@matthieuauger
Copy link
Copy Markdown
Author

hello @pankajastro tests should be good now, just need your approval to execute tests again on CI

@matthieuauger
Copy link
Copy Markdown
Author

@pankajastro is this normal that my CI is blocked? Thanks

@tatiana tatiana added this to the Cosmos 1.13.0 milestone Dec 18, 2025
@codecov
Copy link
Copy Markdown

codecov Bot commented Dec 22, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.81%. Comparing base (80b7abd) to head (b244f00).
⚠️ Report is 63 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2163   +/-   ##
=======================================
  Coverage   97.81%   97.81%           
=======================================
  Files          93       93           
  Lines        6006     6006           
=======================================
  Hits         5875     5875           
  Misses        131      131           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@pankajastro
Copy link
Copy Markdown
Contributor

@pankajastro is this normal that my CI is blocked? Thanks

Yes, for security reasons and to avoid potential misuse, CI requires approval.

@pankajastro
Copy link
Copy Markdown
Contributor

I know the duplicated log lines aren’t ideal, but I think it’s important to understand why they’re happening.

@pankajastro
Copy link
Copy Markdown
Contributor

I know the duplicated log lines aren’t ideal, but I think it’s important to understand why they’re happening.

I tried running a few DAGs and couldn’t see duplicate logs. We may need a broader discussion about changing the log level and deciding what we should and shouldn’t log.

@pankajastro
Copy link
Copy Markdown
Contributor

These logs are helpful for many users—they make it easier to understand what’s happening under the hood and also give a rough idea of performance.

PR #2235 adds Airflow ::group:: to group logs. I think the changes in the PR: #2235 will significantly improve readability, and we may not need to change the log level to debug.

Comment thread cosmos/dbt/graph.py
Comment on lines +579 to +580
logger.debug("Total nodes: %i", len(self.nodes))
logger.debug("Total filtered nodes: %i", len(self.filtered_nodes))
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we can combine both and keep keep as info

@pankajastro
Copy link
Copy Markdown
Contributor

Closing since PR: #2235 has improved the readability, and we will cut alpha soon for testing

@pankajastro pankajastro closed this Jan 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[DX] Move a few logs to the debug channel

4 participants