Fix ExecutionMode.WATCHER to use install_dbt_deps from ProjectConfig#2112
Conversation
michal-mrazek
temporarily deployed
to
external
GitHub Actions
Inactive
✅ Deploy Preview for sunny-pastelito-5ecb04 canceled.
|
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a bug where the ExecutionMode.WATCHER execution mode was not respecting the install_dbt_deps setting from ProjectConfig, unlike the LOCAL and VIRTUALENV execution modes. The change aligns the behavior of WATCHER mode with the documentation and the other execution modes.
Key Changes:
- Updated the condition in
override_configurationfunction to includeExecutionMode.WATCHERalongsideLOCALandVIRTUALENVwhen determining whether to useProjectConfig.install_dbt_deps - Added comprehensive test cases covering all combinations of
WATCHERmode with variousinstall_depsconfigurations
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| cosmos/converter.py | Added ExecutionMode.WATCHER to the conditional check for applying install_dbt_deps from ProjectConfig |
| tests/test_converter.py | Added test cases for ExecutionMode.WATCHER with different install_deps configurations and updated test documentation |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2112 +/- ##
=======================================
Coverage 97.81% 97.81%
=======================================
Files 92 92
Lines 5948 5948
=======================================
Hits 5818 5818
Misses 130 130 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
tatiana
left a comment
tatiana
left a comment
There was a problem hiding this comment.
This looks great, thank you very much, @michal-mrazek ! We'll release this fix as part of Cosmos 1.11.1
…nfig` (#2112) With the new ExecutionMode.WATCHER, the decision if we install dbt deps should be done in the same manner as LOCAL or VIRTUALENV execution modes. So I am changing the code to use the ProjectConfig settings for dbt deps to also work with the Watcher and now it will be in sync with the documentation. Closes: #2099 (cherry picked from commit ce87c97)
Description
With the new ExecutionMode.WATCHER, the decision if we install dbt deps should be done in the same manner as LOCAL or VIRTUALENV execution modes.
So I am changing the code to use the ProjectConfig settings for dbt deps to also work with the Watcher and now it will be in sync with the documentation.
Related Issue(s)
#2099
Breaking Change?
No
Checklist